Re: [PATCH] apple-gmux: Fix kconfig dependencies

Randy Dunlap
2012-08-02T20:20:35Z

On 08/02/2012 10:15 AM, Seth Forshee wrote:

> Fix the dependencies of apple-gmux to prevent it from being built-in
> when one or more of its dependencies is built as a module. Otherwise it
> can fail to build due to missing symbols.
>
> v2: Add dependency on ACPI to fix build failure when ACPI=n
>
> Reported-by: Arun Raghavan <arun.raghavan@collabora.co.uk>
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>

Acked-by: Randy Dunlap <rdunlap@xenotime.net>

Thanks.

> ---
> drivers/platform/x86/Kconfig | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 2a262f5..637074d 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -758,8 +758,11 @@ config SAMSUNG_Q10
>
> config APPLE_GMUX
> tristate "Apple Gmux Driver"
> + depends on ACPI
> depends on PNP
> - select BACKLIGHT_CLASS_DEVICE
> + depends on BACKLIGHT_CLASS_DEVICE
> + depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE
> + depends on ACPI_VIDEO=n || ACPI_VIDEO
> ---help---
> This driver provides support for the gmux device found on many
> Apple laptops, which controls the display mux for the hybrid

--
~Randy