Re: [PATCH] apple-gmux: Fix kconfig dependencies

Randy Dunlap
2012-07-23T15:29:07Z

On 07/23/2012 06:44 AM, Seth Forshee wrote:

> On Mon, Jul 23, 2012 at 02:30:10PM +0100, Matthew Garrett wrote:
>>> I'm looking at Andreas's code for switcharoo support, and something I
>>> want to do along with it is make apple-gmux not dependent on backlight
>>> support (i.e. you can still build switcharoo support if
>>> BACKLIGHT_CLASS_DEVICE is disabled). I'm assuming this patch as a
>>> prerequisite. But things do get really monstrously ugly, so if there's a
>>> cleaner way to enforce this that I haven't found I'd love to hear about
>>> it.
>>
>> Why do you want to support that case? One of the problems we have with
>> the kernel at present is that it's trivial to come up with non-sensical
>> configurations. I can't think of a single case where you'd want the gmux
>> support without also having the backlight support code.
>
> Just because there isn't strictly any reason that the switching code
> needs to depend on backlight support. But yes, I can't think of a good
> reason why anyone would want this configuration. I won't mess with it
> then.

then it should be required in Kconfig file(s), not left to
create build errors.

--
~Randy