From: "J. Bruce Fields" <bfields@fieldses.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
"J. Bruce Fields" <bfields@redhat.com>
Subject: Re: Remove easily user-triggerable BUG from generic_setlease
Date: Mon, 23 Jul 2012 15:04:22 -0400 [thread overview]
Message-ID: <20120723190422.GA2703@fieldses.org> (raw)
In-Reply-To: <CA+55aFxGuoxbdxy3uKX063vZ1xSRhshRyWf_UhMnDL_by7j9Sg@mail.gmail.com>
On Mon, Jul 23, 2012 at 11:34:56AM -0700, Linus Torvalds wrote:
> On Mon, Jul 23, 2012 at 8:20 AM, J. Bruce Fields <bfields@fieldses.org> wrote:
> >
> > So we need something like the following, backported to 2.6.anything.
>
> Please add a note about the 3.2+ version of this patch (well, totally
> different patch), and why this particular patch isn't needed there.
>
> For stable, we should always have a pointer to the patch in mainline,
> and if mainline has a different solution, and note about *why*
> mainline has that different solution.
Right, I wasn't clear: that patch should go to mainline as well.
(Then, do we still want Dave's patch?: in some sense that BUG() was
correct, as the code was obviously intended to catch illegal values
earlier. And having the BUG() means we found the problem quickly
instead of having to track down memory corruption. On the other hand,
agreed that BUG()'ing under a spin lock is cruel. Maybe we should stick
a WARN there if it's not overkill.)
--b.
next prev parent reply other threads:[~2012-07-23 19:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 17:35 Remove easily user-triggerable BUG from generic_setlease Dave Jones
2012-07-13 17:47 ` Linus Torvalds
2012-07-13 17:50 ` Dave Jones
2012-07-23 15:20 ` J. Bruce Fields
2012-07-23 18:34 ` Linus Torvalds
2012-07-23 19:04 ` J. Bruce Fields [this message]
2012-07-23 19:09 ` Linus Torvalds
2012-07-23 19:17 ` [PATCH] locks: fix checking of fcntl_setlease argument J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120723190422.GA2703@fieldses.org \
--to=bfields@fieldses.org \
--cc=bfields@redhat.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox