From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754018Ab2GXMzS (ORCPT ); Tue, 24 Jul 2012 08:55:18 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:46493 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753812Ab2GXMzR (ORCPT ); Tue, 24 Jul 2012 08:55:17 -0400 Date: Tue, 24 Jul 2012 13:55:14 +0100 From: Mark Brown To: Bryan Wu Cc: shuahkhan@gmail.com, "Kim, Milo" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] leds: add new lp8788 led driver Message-ID: <20120724125513.GG12438@opensource.wolfsonmicro.com> References: <1342799346.5138.7.camel@lorien2> <20120722181956.GA4557@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XRI2XbIfl/05pQwm" Content-Disposition: inline In-Reply-To: X-Cookie: You are always busy. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --XRI2XbIfl/05pQwm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 24, 2012 at 08:23:00AM +0800, Bryan Wu wrote: > On Mon, Jul 23, 2012 at 2:19 AM, Mark Brown > > If the work is flushed then the state that userspace thought was set > > when the driver is removed will actually be set before the driver is > > removed. This is fairly minor but might be useful. > So what's kind of state you mentioned here that is cared by user > space. I find these 2 functions are quite confused for use right now. Any state - none of the drivers with sleeping I/O can do anything directly in their callbacks so they defer everything to work (we really should have that in the core but it was too annoying to implement last time I looked). > Literally, canceling normally will remove pending work item and wait > for running work item to finish. flushing will wait for both pending > and running work item to finish. Right, so if we flush it means we know that any scheduled work actually ran and implemented whatever change was requested. --XRI2XbIfl/05pQwm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJQDpslAAoJEBus8iNuMP3dEocP/0VnluuSK03w00QcG/BBICQ6 Ca+x6TIhtDg1Q49XOhBo0qurX71xIDjmtGtns6umYAShcTNAV/44jUeOLhN9KFp1 SdGORe+mo2Je9yHDsgf+Iox1AlZ4EUHQ1Vt+jpikHMuWT84FJpXqSAJFgadLRhaV +n6GyyctwKyyIoEQcmc3IOCFnGjowLgQkKMK5RW28DvH0ErdhkrFIUP02s3voGaj FxxZ0ddPGuet+G5pNgUbq/i/pHU++jq1Qi+ojJxYyt3hcfXm/4XD9dkOKi5OCpnc QQLwuBJnu/EURDOyTwzm8TuvlNg4uFpsTnwNTEdSYfuCR2C77KoYNuddcGUQ5c/q 6a2k7I5dEX3Xm5QUJEUP8qcUebI/Wu6gCSkKEmlx9Ror+Ohz+hqEroHN1L8b7TpO WhGt24eXlFNpHy10JXYA4sUTyPUC9Uol/FWXkm0wM9thBzBMhShupk3OFFZtv9CG 17oqwP16YcSwXWGtM7lzkoaSwKThEzdyo0r+TvBNsmnESz/32sCJXlaW4phJdwRj kaMebgCjFTxxGpfqpPuLy0q9n1uG9/KxZDWpi7ff8VI4OtgnnS8xZJ9pInSI63ex 4T+SSXopdGDeuMFNndcmIM/UunGDcsR+Qs4V30nwn1UcSzy+tauvwwHbvS8yCxAS RLcGc0/MQmYzJ23ZAQIE =sRP+ -----END PGP SIGNATURE----- --XRI2XbIfl/05pQwm--