Re: [PATCH 08/17] Tools: hv: Gather subnet information

Ben Hutchings
2012-07-25T01:14:18Z

[-- Attachment #1: Type: text/plain, Size: 1559 bytes --]

On Tue, 2012-07-24 at 09:01 -0700, K. Y. Srinivasan wrote:
> Now gather sub-net information for the specified interface.
>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
> ---
> tools/hv/hv_kvp_daemon.c | 31 +++++++++++++++++++++++++++++--
> 1 files changed, 29 insertions(+), 2 deletions(-)
>
> diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
> index 79eb130..2c24ebf 100644
> --- a/tools/hv/hv_kvp_daemon.c
> +++ b/tools/hv/hv_kvp_daemon.c
> @@ -534,6 +534,7 @@ kvp_get_ip_address(int family, char *if_name, int op,
> struct ifaddrs *ifap;
> struct ifaddrs *curp;
> int offset = 0;
> + int sn_offset = 0;
> const char *str;
> int error = 0;
> char *buffer;
> @@ -594,12 +595,38 @@ kvp_get_ip_address(int family, char *if_name, int op,
> * Gather info other than the IP address.
> * IP address info will be gathered later.
> */
> - if (curp->ifa_addr->sa_family == AF_INET)
> + if (curp->ifa_addr->sa_family == AF_INET) {
> ip_buffer->addr_family |= ADDR_FAMILY_IPV4;
> - else
> + /*
> + * Get subnet info.
> + */
> + error = kvp_process_ip_address(
> + curp->ifa_netmask,
> + AF_INET,
> + (char *)
> + ip_buffer->sub_net,
> + length,
> + &sn_offset);
[...]

This is barely readable; why don't you indent the arguments by just one
extra tab?

Ben.

--
Ben Hutchings
If more than one person is responsible for a bug, no one is at fault.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]