* [PATCH] staging: bcm: use SEEK_SET instead of 0 in vfs_llseek
@ 2012-07-24 15:55 Vivek Trivedi
2012-07-25 1:23 ` Kevin McKinney
0 siblings, 1 reply; 2+ messages in thread
From: Vivek Trivedi @ 2012-07-24 15:55 UTC (permalink / raw)
To: Greg Kroah-Hartman, Kevin McKinney, Dan Carpenter, devel,
linux-kernel
Cc: Vivek Trivedi, Namjae Jeon
They're equivalent, but SEEK_SET seems more informative...
Signed-off-by: Vivek Trivedi <vtrivedi018@gmail.com>
Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
---
drivers/staging/bcm/Misc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c
index 8223a69..8fab3ec 100644
--- a/drivers/staging/bcm/Misc.c
+++ b/drivers/staging/bcm/Misc.c
@@ -203,7 +203,7 @@ static int BcmFileDownload(PMINI_ADAPTER Adapter, const char *path, unsigned int
}
oldfs = get_fs();
set_fs(get_ds());
- vfs_llseek(flp, 0, 0);
+ vfs_llseek(flp, 0, SEEK_SET);
set_fs(oldfs);
if (Adapter->bcm_file_readback_from_chip(Adapter->pvInterfaceAdapter, flp, loc)) {
BCM_DEBUG_PRINT(Adapter, DBG_TYPE_INITEXIT, MP_INIT, DBG_LVL_ALL, "Failed to read back firmware!");
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: bcm: use SEEK_SET instead of 0 in vfs_llseek
2012-07-24 15:55 [PATCH] staging: bcm: use SEEK_SET instead of 0 in vfs_llseek Vivek Trivedi
@ 2012-07-25 1:23 ` Kevin McKinney
0 siblings, 0 replies; 2+ messages in thread
From: Kevin McKinney @ 2012-07-25 1:23 UTC (permalink / raw)
To: Vivek Trivedi, Greg Kroah-Hartman, Dan Carpenter, devel,
linux-kernel
On Tue, Jul 24, 2012 at 09:25:04PM +0530, Vivek Trivedi wrote:
> They're equivalent, but SEEK_SET seems more informative...
>
> Signed-off-by: Vivek Trivedi <vtrivedi018@gmail.com>
> Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
> ---
> drivers/staging/bcm/Misc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c
> index 8223a69..8fab3ec 100644
> --- a/drivers/staging/bcm/Misc.c
> +++ b/drivers/staging/bcm/Misc.c
> @@ -203,7 +203,7 @@ static int BcmFileDownload(PMINI_ADAPTER Adapter, const char *path, unsigned int
> }
> oldfs = get_fs();
> set_fs(get_ds());
> - vfs_llseek(flp, 0, 0);
> + vfs_llseek(flp, 0, SEEK_SET);
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-25 1:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-24 15:55 [PATCH] staging: bcm: use SEEK_SET instead of 0 in vfs_llseek Vivek Trivedi
2012-07-25 1:23 ` Kevin McKinney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox