From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] extcon: arizona: Implement button detection support
Date: Wed, 25 Jul 2012 12:11:06 +0100 [thread overview]
Message-ID: <20120725111105.GI3099@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <500F8DB4.30401@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 874 bytes --]
On Wed, Jul 25, 2012 at 03:09:56PM +0900, Chanwoo Choi wrote:
> On 07/21/2012 01:07 AM, Mark Brown wrote:
Please delete irrelevant context from your replies, it makes it much
easier to find what you're saying.
> Why do you should report released event to all of buttons? I think that
> you should only
> report released event to previous pressed button. If user press two
> button on the headset
> at the same time and then user release only one button with pressed
> another button, extcon-arizona driver have to report released event to
> previous pressed button except for still pressed another button.
The input API already supresses duplicate reports, they won't be
propagated to userspace, so there's no point in duplicating the work
to remember what buttons are pressed in individual drivers. Userspace
will only see events reported that refect changes in state.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-07-25 11:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 16:07 [PATCH] extcon: arizona: Implement button detection support Mark Brown
2012-07-25 6:09 ` Chanwoo Choi
2012-07-25 11:11 ` Mark Brown [this message]
2012-07-26 0:10 ` Chanwoo Choi
2012-07-26 8:11 ` Mark Brown
2012-07-27 6:45 ` Chanwoo Choi
2012-08-04 6:37 ` anish kumar
2012-08-04 10:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120725111105.GI3099@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox