From: Oleg Nesterov <oleg@redhat.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Kees Cook <keescook@chromium.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: yama_ptrace_access_check(): possible recursive locking detected
Date: Thu, 26 Jul 2012 17:41:44 +0200 [thread overview]
Message-ID: <20120726154144.GA20964@redhat.com> (raw)
In-Reply-To: <20120726134748.GA20605@localhost>
On 07/26, Fengguang Wu wrote:
>
> Here is a recursive lock possibility:
>
> ptrace_may_access()
> => task_lock(task);
> yama_ptrace_access_check()
> get_task_comm()
> => task_lock(task);
I think yama_ptrace_access_check() can simply use ->comm
Oleg.
--- x/security/yama/yama_lsm.c
+++ x/security/yama/yama_lsm.c
@@ -279,12 +279,9 @@ static int yama_ptrace_access_check(stru
}
if (rc) {
- char name[sizeof(current->comm)];
printk_ratelimited(KERN_NOTICE
"ptrace of pid %d was attempted by: %s (pid %d)\n",
- child->pid,
- get_task_comm(name, current),
- current->pid);
+ child->pid, current->comm, current->pid);
}
return rc;
next prev parent reply other threads:[~2012-07-26 15:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 13:47 yama_ptrace_access_check(): possible recursive locking detected Fengguang Wu
2012-07-26 15:41 ` Oleg Nesterov [this message]
2012-07-30 17:00 ` Kees Cook
2012-08-10 1:39 ` Kees Cook
2012-08-10 1:52 ` Fengguang Wu
2012-08-14 21:16 ` Kees Cook
2012-08-15 3:01 ` Fengguang Wu
2012-08-15 5:56 ` Kees Cook
2012-08-15 8:05 ` Peter Zijlstra
2012-08-15 13:01 ` Oleg Nesterov
2012-08-15 14:30 ` Peter Zijlstra
2012-08-15 17:56 ` Oleg Nesterov
2012-08-15 18:09 ` Kees Cook
2012-08-15 18:17 ` Oleg Nesterov
2012-08-15 18:30 ` Kees Cook
2012-08-15 18:44 ` Alan Cox
2012-08-15 18:43 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120726154144.GA20964@redhat.com \
--to=oleg@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox