From: Oleg Nesterov <oleg@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>, Tejun Heo <tj@kernel.org>,
Peter Boonstoppel <pboonstoppel@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
Andy Walls <awalls@md.metrocast.net>,
Diwakar Tundlam <dtundlam@nvidia.com>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 1/1] kthread: disable preemption during complete()
Date: Thu, 26 Jul 2012 17:54:09 +0200 [thread overview]
Message-ID: <20120726155409.GB20964@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1207261242240.32033@ionos>
On 07/26, Thomas Gleixner wrote:
>
> On Thu, 26 Jul 2012, Peter Zijlstra wrote:
> > On Wed, 2012-07-25 at 15:40 -0700, Tejun Heo wrote:
> > > > This patch disables preemption during complete(), since we call
> > > > schedule() directly afterwards, so it will correctly enter
> > > > TASK_UNINTERRUPTIBLE. This speeds up kthread creation/binding during
> > > > cpu hotplug significantly.
> >
> > tglx has patches that make the kthread create/destroy stuff from hotplug
> > go away.. that seems like the better approach.
>
> Right. That cpu hotplug setup/teardown stuff is ugly.
Could you cc me if you send these patches?
> > The comment doesn't really make that clear.
>
> Right, the comment is crap. It has nothing to do with kthread_bind()
> and stuff. The whole purpose is to avoid the pointless preemption
> after wakeup.
Yes, but this "avoid the preemption after wakeup" can actually help
kthread_bind()->wait_task_inactive() ?
This reminds me, Peter had a patch which teaches wait_task_inactive()
to use sched_in/sched_out notifiers to avoid the polling...
Oleg.
next prev parent reply other threads:[~2012-07-26 15:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 0:05 [PATCH 1/1] kthread: disable preemption during complete() Peter Boonstoppel
2012-07-25 0:09 ` Tejun Heo
2012-07-25 22:35 ` Peter Boonstoppel
2012-07-25 22:40 ` Tejun Heo
2012-07-26 8:04 ` Peter Zijlstra
2012-07-26 10:47 ` Thomas Gleixner
2012-07-26 15:54 ` Oleg Nesterov [this message]
2012-07-26 19:29 ` Peter Zijlstra
2012-07-26 21:16 ` Peter Boonstoppel
2012-08-01 7:14 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120726155409.GB20964@redhat.com \
--to=oleg@redhat.com \
--cc=awalls@md.metrocast.net \
--cc=dtundlam@nvidia.com \
--cc=ibm-acpi@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paul.gortmaker@windriver.com \
--cc=pboonstoppel@nvidia.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox