From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Liam Girdwood <lrg@ti.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: regulators: creating a regulator device for the AC/USB/BAT/charge component of a PMIC?
Date: Thu, 26 Jul 2012 22:01:15 +0100 [thread overview]
Message-ID: <20120726210115.GF4560@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <50118637.9060205@wwwdotorg.org>
[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]
On Thu, Jul 26, 2012 at 12:02:31PM -0600, Stephen Warren wrote:
> A couple of the regulators I'm looking at (I guess many/most in fact)
> are structured as:
> Battery, AC, USB, ... -> PMIC -> main output (unregulated?)
Yes, that's very normal.
> Should this "main output" be represented as a regulator itself?
It can be if you like - most things will be depending on it, often what
people call the battery supply is actually the main power rail in the
schematic. Having it there certainly won't do any harm and may be
useful.
> However, some of the regulators in the TPS6586x at least are fed
> directly from the SYS output by an internal connection within the PMIC
> (e.g. LDO5). Currently, the driver sets up these regulators as having no
> supply, which seems wrong too. Presumably the PMIC driver should
> internally hook up its SYS as LDO5's supply without needing any platform
> data or DT ldo5-supply property to do this?
Yes, I think if we're going to represent such supplies the driver should
just do it and not force everyone to cut'n'paste. Though to be honest
if it's a supply that's purely internal to the primary PMIC there's no
real need, if the system core rail gets turned off software really isn't
an issue any more.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-07-26 21:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 18:02 regulators: creating a regulator device for the AC/USB/BAT/charge component of a PMIC? Stephen Warren
2012-07-26 21:01 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120726210115.GF4560@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox