From: Sam Ravnborg <sam@ravnborg.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT PULL] x86/build change for v3.6
Date: Sun, 29 Jul 2012 22:42:40 +0200 [thread overview]
Message-ID: <20120729204240.GA26530@merkur.ravnborg.org> (raw)
In-Reply-To: <20120726065506.GA8421@gmail.com>
On Thu, Jul 26, 2012 at 08:55:06AM +0200, Ingo Molnar wrote:
>
> * Sam Ravnborg <sam@ravnborg.org> wrote:
>
> > >
> > > No, the reason for the odd looking diff is that lots of lines in
> > > arch/x86/Makefile have 8-space tabs for histerical reasons but
> > > new code (such as this one) has proper tabs.
> >
> > Use of tabs for indent in a Makefile is just asking for
> > trouble.
>
> Ok, I guess you are right - see the patch below which was
> another type of bug that could be introduced via not using
> spaces properly.
>
> We could do it the other way around: turn all tabs into spaces
> and add Makefile checking in kbuild so that the build fails if
> a tab is added to a Makefile?
>
> Alternatively, is there perhaps some way to teach make to not be
> so broken to depend on whitespace details that are *invisible*
> to humans?
We can teach make to use something else - say "€" - as the command idicator.
But that would confuse people a lot.
If we follow hpa's suggestion to use 4 spaces as indent then it
more obvious that we do not use tabs for indent.
For that matter we could consider 3 spaces - so two indents is not
the same as one tab.
If we one day use a tool for parsing up all the kbuild files
then we could always add checks in that tool.
but today make does not allow us to do so.
At least not that I know.
Sam
prev parent reply other threads:[~2012-07-29 20:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-22 13:44 [GIT PULL] x86/build change for v3.6 Ingo Molnar
2012-07-22 13:58 ` Kirill A. Shutemov
2012-07-22 14:22 ` Ingo Molnar
2012-07-23 9:35 ` Kirill A. Shutemov
2012-07-25 20:15 ` Sam Ravnborg
2012-07-25 20:18 ` H. Peter Anvin
2012-07-26 6:55 ` Ingo Molnar
2012-07-29 20:42 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120729204240.GA26530@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).