From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>,
Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH 2/3] regmap: implement irq chip suspend/resume operations
Date: Sun, 29 Jul 2012 22:04:10 +0100 [thread overview]
Message-ID: <20120729210410.GM4384@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1343415716-27134-2-git-send-email-swarren@wwwdotorg.org>
On Fri, Jul 27, 2012 at 01:01:55PM -0600, Stephen Warren wrote:
> When suspending, we set up the wake mask registers as required. Some
> chips don't have separate wake mask registers, so they set mask_base
> equal to wake_base. In that case, when resuming, we re-program the
No, they shouldn't be doing that at all - that's at best confused. The
two registers do different things and if the two ranges are set the same
then I'd not expect things to work. Supporting that would make the code
more complex and I'm not sure what benefit we might gain from it.
next prev parent reply other threads:[~2012-07-29 21:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 19:01 [PATCH 1/3] regmap: fix some error messages to take account of irq_reg_stride Stephen Warren
2012-07-27 19:01 ` [PATCH 2/3] regmap: implement irq chip suspend/resume operations Stephen Warren
2012-07-29 21:04 ` Mark Brown [this message]
2012-07-30 17:10 ` Stephen Warren
2012-07-30 17:38 ` Mark Brown
2012-07-31 19:25 ` Stephen Warren
2012-08-01 13:56 ` Mark Brown
2012-07-27 19:01 ` [PATCH 3/3] regmap: enhance regmap-irq to handle 1 IRQ feeding n chips Stephen Warren
2012-07-29 20:36 ` Mark Brown
2012-07-30 17:00 ` Stephen Warren
2012-07-30 17:25 ` Mark Brown
2012-07-31 23:18 ` Stephen Warren
2012-08-01 11:41 ` Mark Brown
2012-08-01 13:56 ` [PATCH 1/3] regmap: fix some error messages to take account of irq_reg_stride Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120729210410.GM4384@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).