From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753592Ab2G3PrL (ORCPT ); Mon, 30 Jul 2012 11:47:11 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:40082 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752875Ab2G3PrJ (ORCPT ); Mon, 30 Jul 2012 11:47:09 -0400 Date: Mon, 30 Jul 2012 16:47:06 +0100 From: Mark Brown To: Rob Herring Cc: Alexandre Courbot , Stephen Warren , Thierry Reding , Simon Glass , Grant Likely , Greg Kroah-Hartman , Arnd Bergmann , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org Subject: Re: [RFC][PATCH v3 1/3] runtime interpreted power sequences Message-ID: <20120730154706.GL4468@opensource.wolfsonmicro.com> References: <1343390750-3642-1-git-send-email-acourbot@nvidia.com> <1343390750-3642-2-git-send-email-acourbot@nvidia.com> <5016ABDD.5010809@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5016ABDD.5010809@gmail.com> X-Cookie: Give him an evasive answer. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 30, 2012 at 10:44:29AM -0500, Rob Herring wrote: > On 07/27/2012 07:05 AM, Alexandre Courbot wrote: > > + power-on-sequence { > > + regulator@0 { > > + id = "power"; > > + enable; > What do this mean? Isn't this implied for a regulator? I assume you might have some sequences which need some things to be turned off for some reason; it at least seems to be something you'd want to design for. > This looks like you designed the platform_data structs first and then > came up with device nodes to mirror the struct. Judging by most of the DT I review this seems idiomatic :)