Re: [PATCH 11/17] Tools: hv: Gather DNS information

Ben Hutchings
2012-07-24T23:38:21Z

On Tue, Jul 24, 2012 at 09:01:35AM -0700, K. Y. Srinivasan wrote:
> Now gather DNS information. This information cannot be gathered in
> a distro independent fashion. Invoke an external script (that can be
> distro dependent) to gather the DNS information.
[...]
> + memset(cmd, 0, sizeof(cmd));
> + strcat(cmd, "/sbin/hv_get_dns_info ");
> + strcat(cmd, if_name);
[...]

This is a weird way to build a string; why are you not using
snprintf()? Not to mention that interface names can contain several
characters that are special to the shell - in fact the only disallowed
characters are / and whitespace.

Also, the external script will not be useful to anything other than
hv_kvp_daemon, so it probably belongs somewhere under /usr/share.

Ben.

--
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
- Albert Camus