From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>,
Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH 2/3] regmap: implement irq chip suspend/resume operations
Date: Mon, 30 Jul 2012 18:38:23 +0100 [thread overview]
Message-ID: <20120730173822.GN4468@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <5016C006.80008@wwwdotorg.org>
On Mon, Jul 30, 2012 at 11:10:30AM -0600, Stephen Warren wrote:
> hence exit sleep. If we are to port that code into the regmap-irq core,
> it seems to make sense to have enable_base==wake_base, since the same
> register truly is being used for both enable/wakeup-enable, just
> time-multiplexed.
This would mean that we have to go round every single driver that
doesn't have physical wake support and add a setting for the wake
registers (which seems pointless given that the core can just as well
figure this out from the fact that it's not had any wake registers
specified) and we then have to add special cases for this in the core
code. This doesn't seem like great API design, it's not conveneint for
either side of the interface and it's error prone.
> Or, perhaps the IRQ core already disables all non-wake interrupts for
> us, so the driver doesn't have to do this, and we can just drop that
> code completely?
IIRC it does actually do this, I'd need to check though.
next prev parent reply other threads:[~2012-07-30 17:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 19:01 [PATCH 1/3] regmap: fix some error messages to take account of irq_reg_stride Stephen Warren
2012-07-27 19:01 ` [PATCH 2/3] regmap: implement irq chip suspend/resume operations Stephen Warren
2012-07-29 21:04 ` Mark Brown
2012-07-30 17:10 ` Stephen Warren
2012-07-30 17:38 ` Mark Brown [this message]
2012-07-31 19:25 ` Stephen Warren
2012-08-01 13:56 ` Mark Brown
2012-07-27 19:01 ` [PATCH 3/3] regmap: enhance regmap-irq to handle 1 IRQ feeding n chips Stephen Warren
2012-07-29 20:36 ` Mark Brown
2012-07-30 17:00 ` Stephen Warren
2012-07-30 17:25 ` Mark Brown
2012-07-31 23:18 ` Stephen Warren
2012-08-01 11:41 ` Mark Brown
2012-08-01 13:56 ` [PATCH 1/3] regmap: fix some error messages to take account of irq_reg_stride Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120730173822.GN4468@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).