From: Evgeniy Polyakov <zbr@ioremap.net>
To: Daniel Mack <zonque@gmail.com>
Cc: linux-kernel@vger.kernel.org, Ville Syrjala <syrjala@sci.fi>,
GregKH <greg@kroah.com>
Subject: Re: [PATCH 1/2] onewire: w1-gpio: add ext_pullup_enable pin in platform data
Date: Mon, 30 Jul 2012 22:12:39 +0400 [thread overview]
Message-ID: <20120730181238.GA23443@ioremap.net> (raw)
In-Reply-To: <1343249670-14985-1-git-send-email-zonque@gmail.com>
Hi
Sorry for long delay
[resend with fixed Greg's address :)]
On Wed, Jul 25, 2012 at 10:54:29PM +0200, Daniel Mack (zonque@gmail.com) wrote:
> In the process of porting boards to devicetree implemenation, we should
> keep information about external circuitry where they belong - the
> individual drivers.
>
> This patch adds a way to specify a GPIO to drive the (optional) external
> pull-up logic, rather than using a function pointer for that.
I do not object against this patch, but I have rather limited knowledge
about gpio driver. Patch looks good, feel free to add my
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Greg, please pull it into your tree, if Ville does not object.
Thank you.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2012-07-30 18:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 20:54 [PATCH 1/2] onewire: w1-gpio: add ext_pullup_enable pin in platform data Daniel Mack
2012-07-25 20:54 ` [PATCH 2/2] onewire: w1-gpio: add DT bindings Daniel Mack
2012-07-30 17:26 ` [PATCH 1/2] onewire: w1-gpio: add ext_pullup_enable pin in platform data Daniel Mack
2012-07-30 17:32 ` Evgeniy Polyakov
2012-07-30 17:35 ` Daniel Mack
2012-07-30 18:12 ` Evgeniy Polyakov [this message]
2012-07-31 0:59 ` Ville Syrjälä
2012-07-31 6:19 ` Daniel Mack
2012-08-01 16:57 ` Ville Syrjälä
2012-08-05 16:18 ` Daniel Mack
2012-08-16 16:57 ` GregKH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120730181238.GA23443@ioremap.net \
--to=zbr@ioremap.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=syrjala@sci.fi \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox