From: Tejun Heo <tj@kernel.org>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [wq:review-wq-mod_delayed] WARNING: at __queue_work()
Date: Mon, 30 Jul 2012 11:39:51 -0700 [thread overview]
Message-ID: <20120730183951.GD20067@google.com> (raw)
In-Reply-To: <20120729052159.GA12776@localhost>
On Sun, Jul 29, 2012 at 01:21:59PM +0800, Fengguang Wu wrote:
> Hi Tejun,
>
> I got the below warning on
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git review-wq-mod_delayed
> head: 6f510bfa84f26319b1021b9e706ebb814809c4a3
> commit: 54eaaeaa4d2b871c835ff826af5dab3b96f90da0 [4/15] workqueue: disable preemption while manipulating PENDING
>
> [ 0.624901] NET: Registered protocol family 1
> [ 0.626536] ------------[ cut here ]------------
> [ 0.627849] WARNING: at /c/kernel-tests/src/tip/kernel/workqueue.c:995 __queue_work+0x33/0x1ab()
> [ 0.630262] Pid: 1, comm: swapper Not tainted 3.5.0-07346-g54eaaea #1043
> [ 0.632100] Call Trace:
> [ 0.632803] [<8102546a>] warn_slowpath_common+0x54/0x69
> [ 0.634246] [<81034e5d>] ? __queue_work+0x33/0x1ab
> [ 0.635578] [<81034e5d>] ? __queue_work+0x33/0x1ab
> [ 0.636944] [<8102551d>] warn_slowpath_null+0x1d/0x20
> [ 0.638344] [<81034e5d>] __queue_work+0x33/0x1ab
> [ 0.639632] [<8103506c>] queue_work_on+0x13/0x1c
> [ 0.640945] [<81035083>] queue_work+0xe/0x10
> [ 0.642137] [<81035136>] queue_delayed_work+0xf/0x22
> [ 0.643525] [<81035642>] schedule_delayed_work+0x11/0x13
> [ 0.645038] [<815a3750>] sunrpc_init_cache_detail+0x7f/0x82
> [ 0.646579] [<815a3db6>] cache_register_net+0x8/0xc
> [ 0.647941] [<815a0520>] ip_map_cache_create+0x34/0x56
> [ 0.649399] [<81ac0ffe>] sunrpc_init_net+0x73/0xce
> [ 0.650743] [<81ac0f8b>] ? init_sunrpc+0x5f/0x5f
> [ 0.652049] [<814f3bba>] ops_init.constprop.5+0xc5/0xeb
> [ 0.653510] [<814f3c34>] register_pernet_operations.isra.2+0x54/0x7d
> [ 0.655325] [<81ac0f2c>] ? rpc_init_generic_auth+0xf/0xf
> [ 0.656821] [<814f3dbb>] register_pernet_subsys+0x19/0x2a
> [ 0.658316] [<81ac0f55>] init_sunrpc+0x29/0x5f
> [ 0.659555] [<81a879cb>] do_one_initcall+0x7e/0x129
> [ 0.660936] [<81a87b59>] kernel_init+0xe3/0x17a
> [ 0.662205] [<81a87435>] ? do_early_param+0x7a/0x7a
> [ 0.663574] [<81a87a76>] ? do_one_initcall+0x129/0x129
> [ 0.665038] [<81652f36>] kernel_thread_helper+0x6/0xd
The WARN_ON should have been on preemptible() instead of directly on
preempt_count(); otherwise, with !CONFIG_PREEMPT_COUNT, the condition
triggers spuriously. Will fix.
Thanks a lot for the report.
--
tejun
prev parent reply other threads:[~2012-07-30 18:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-29 5:21 [wq:review-wq-mod_delayed] WARNING: at __queue_work() Fengguang Wu
2012-07-30 18:39 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120730183951.GD20067@google.com \
--to=tj@kernel.org \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).