From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754723Ab2G3TTZ (ORCPT ); Mon, 30 Jul 2012 15:19:25 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:44728 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753487Ab2G3TTX (ORCPT ); Mon, 30 Jul 2012 15:19:23 -0400 Date: Mon, 30 Jul 2012 20:19:13 +0100 From: Ben Hutchings To: KY Srinivasan Cc: Olaf Hering , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "apw@canonical.com" , "netdev@vger.kernel.org" Message-ID: <20120730191912.GH1894@decadent.org.uk> References: <1343145672-3641-1-git-send-email-kys@microsoft.com> <1343145701-3691-1-git-send-email-kys@microsoft.com> <1343145701-3691-13-git-send-email-kys@microsoft.com> <20120730180326.GB533@aepfle.de> <426367E2313C2449837CD2DE46E7EAF9236AA7DB@SN2PRD0310MB382.namprd03.prod.outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <426367E2313C2449837CD2DE46E7EAF9236AA7DB@SN2PRD0310MB382.namprd03.prod.outlook.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: ben@decadent.org.uk Subject: Re: [PATCH 13/17] Tools: hv: Implement the KVP verb - KVP_OP_SET_IP_INFO X-SA-Exim-Version: 4.2.1 (built Mon, 22 Mar 2010 06:51:10 +0000) X-SA-Exim-Scanned: Yes (on shadbolt.decadent.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 30, 2012 at 06:32:15PM +0000, KY Srinivasan wrote: > > > > -----Original Message----- > > From: Olaf Hering [mailto:olaf@aepfle.de] > > Sent: Monday, July 30, 2012 2:03 PM > > To: KY Srinivasan > > Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org; > > devel@linuxdriverproject.org; apw@canonical.com; netdev@vger.kernel.org; > > ben@decadent.org.uk > > Subject: Re: [PATCH 13/17] Tools: hv: Implement the KVP verb - > > KVP_OP_SET_IP_INFO > > > > On Tue, Jul 24, K. Y. Srinivasan wrote: > > > > > + /* > > > + * Set the configuration for the specified interface with > > > + * the information provided. Since there is no standard > > > + * way to configure an interface, we will have an external > > > + * script that does the job of configuring the interface and > > > + * flushing the configuration. > > > + * > > > + * The parameters passed to this external script are: > > > + * 1. A configuration file that has the specified configuration. > > > > Maybe this should be written as 'A info file that has the requested > > network configuration' or something like that. > > That is the idea. This configuration file simply reflects all the > information we have perhaps with some additional constant > information. The script is free to ignore what it does not need. [...] This does not strike me as a sensible interface. If scripts are 'free to ignore' information then the KVP interface becomes unreliable as a means for managing networking on Linux guests. I would suggest that at the least the script should be able to report that it did not recognise some parts of the configuration. This would be logged and/or reported back to the hypervisor. (This is separate from the issue of constant configuration lines; for some distributions the script might recognise but ignore them because they have no use on that distribution. I don't see the point in constant lines, but they don't seem to result in any unreliability.) Ben. -- Ben Hutchings We get into the habit of living before acquiring the habit of thinking. - Albert Camus