From: "Ville Syrjälä" <syrjala@sci.fi>
To: Evgeniy Polyakov <zbr@ioremap.net>
Cc: Daniel Mack <zonque@gmail.com>,
linux-kernel@vger.kernel.org, GregKH <greg@kroah.com>
Subject: Re: [PATCH 1/2] onewire: w1-gpio: add ext_pullup_enable pin in platform data
Date: Tue, 31 Jul 2012 03:59:29 +0300 [thread overview]
Message-ID: <20120731005929.GP27847@sci.fi> (raw)
In-Reply-To: <20120730181238.GA23443@ioremap.net>
On Mon, Jul 30, 2012 at 10:12:39PM +0400, Evgeniy Polyakov wrote:
> Hi
>
> Sorry for long delay
> [resend with fixed Greg's address :)]
>
> On Wed, Jul 25, 2012 at 10:54:29PM +0200, Daniel Mack (zonque@gmail.com) wrote:
> > In the process of porting boards to devicetree implemenation, we should
> > keep information about external circuitry where they belong - the
> > individual drivers.
> >
> > This patch adds a way to specify a GPIO to drive the (optional) external
> > pull-up logic, rather than using a function pointer for that.
>
> I do not object against this patch, but I have rather limited knowledge
> about gpio driver. Patch looks good, feel free to add my
> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
>
> Greg, please pull it into your tree, if Ville does not object.
No objections from me.
The only cosmetic issue I spotted was 'pdata' being assigned twice in
w1_gpio_probe().
--
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/
next prev parent reply other threads:[~2012-07-31 1:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 20:54 [PATCH 1/2] onewire: w1-gpio: add ext_pullup_enable pin in platform data Daniel Mack
2012-07-25 20:54 ` [PATCH 2/2] onewire: w1-gpio: add DT bindings Daniel Mack
2012-07-30 17:26 ` [PATCH 1/2] onewire: w1-gpio: add ext_pullup_enable pin in platform data Daniel Mack
2012-07-30 17:32 ` Evgeniy Polyakov
2012-07-30 17:35 ` Daniel Mack
2012-07-30 18:12 ` Evgeniy Polyakov
2012-07-31 0:59 ` Ville Syrjälä [this message]
2012-07-31 6:19 ` Daniel Mack
2012-08-01 16:57 ` Ville Syrjälä
2012-08-05 16:18 ` Daniel Mack
2012-08-16 16:57 ` GregKH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120731005929.GP27847@sci.fi \
--to=syrjala@sci.fi \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox