From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754070Ab2GaONd (ORCPT ); Tue, 31 Jul 2012 10:13:33 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:53406 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752135Ab2GaONb (ORCPT ); Tue, 31 Jul 2012 10:13:31 -0400 Date: Tue, 31 Jul 2012 15:13:29 +0100 From: Mark Brown To: Thierry Reding Cc: Alex Courbot , Stephen Warren , Stephen Warren , Simon Glass , Grant Likely , Rob Herring , Greg Kroah-Hartman , Arnd Bergmann , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" Subject: Re: [RFC][PATCH v3 1/3] runtime interpreted power sequences Message-ID: <20120731141328.GS4468@opensource.wolfsonmicro.com> References: <1343390750-3642-1-git-send-email-acourbot@nvidia.com> <1343390750-3642-2-git-send-email-acourbot@nvidia.com> <50170EA0.1010408@wwwdotorg.org> <5017B434.2010706@nvidia.com> <20120731105640.GD16155@avionic-0098.adnet.avionic-design.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120731105640.GD16155@avionic-0098.adnet.avionic-design.de> X-Cookie: Give him an evasive answer. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 31, 2012 at 12:56:40PM +0200, Thierry Reding wrote: > On Tue, Jul 31, 2012 at 07:32:20PM +0900, Alex Courbot wrote: > > The thing is that I am not sure what happens to the platform data > > once probe() is done. Isn't it customary to mark it with __devinit > > and have it freed after probing is successful? > No, platform data should stay around forever. Otherwise, consider what > would happen if your driver is built as a module and you unload and load > it again. __devinit can be discarded if you disable enough kernel features, HOTPLUG is the main one IIRC, modules might also need to go - drivers really ought to take a copy of platform data they plan to use at runtime, though practically speaking you have to try to trigger any problems.