From: Tejun Heo <tj@kernel.org>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, padovan@profusion.mobi,
marcel@holtmann.org, peterz@infradead.org, mingo@redhat.com,
davem@davemloft.net, dougthompson@xmission.com,
ibm-acpi@hmh.eng.br, cbou@mail.ru, rui.zhang@intel.com,
Jens Axboe <axboe@kernel.dk>, Jiri Kosina <jkosina@suse.cz>,
Roland Dreier <roland@kernel.org>
Subject: Re: [PATCH 15/15] workqueue: deprecate __cancel_delayed_work()
Date: Tue, 31 Jul 2012 10:11:46 -0700 [thread overview]
Message-ID: <20120731171146.GA21292@google.com> (raw)
In-Reply-To: <1343739939.2633.34.camel@deskari>
On Tue, Jul 31, 2012 at 04:05:39PM +0300, Tomi Valkeinen wrote:
> > Use cancel_delayed_work() instead of __cancel_delayed_work() and mark
> > the latter deprecated.
>
> I used __cancel_delayed_work() in drivers/video/omap2/dss/dsi.c as the
> cancel is done in an interrupt handler. Is it safe to use
> cancel_delayed_work() in atomic context? I presume not, as it uses
> del_timer_sync().
Ah, you're right. __cancel_delayed_work() invoked from irq context
can't be converted to cancel_delayed_work() or mod_delayed_work().
I'll skip those from the previous patch and drop this patch. I really
hope this could be solved somehow tho. :(
Thank you.
--
tejun
next prev parent reply other threads:[~2012-07-31 17:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 23:54 [PATCHSET wq/for-3.7] workqueue: implement mod_delayed_work[_on]() Tejun Heo
2012-07-27 23:54 ` [PATCH 01/15] workqueue: reorder queueing functions so that _on() variants are on top Tejun Heo
2012-07-27 23:54 ` [PATCH 02/15] workqueue: make queueing functions return bool Tejun Heo
2012-07-27 23:54 ` [PATCH 03/15] workqueue: add missing smp_wmb() in process_one_work() Tejun Heo
2012-07-27 23:54 ` [PATCH 04/15] workqueue: disable preemption while manipulating PENDING Tejun Heo
2012-07-30 20:10 ` [PATCH v2 " Tejun Heo
2012-07-27 23:54 ` [PATCH 05/15] workqueue: set delayed_work->timer function on initialization Tejun Heo
2012-07-27 23:54 ` [PATCH 06/15] workqueue: unify local CPU queueing handling Tejun Heo
2012-07-27 23:55 ` [PATCH 07/15] workqueue: fix zero @delay handling of queue_delayed_work_on() Tejun Heo
2012-07-27 23:55 ` [PATCH 08/15] workqueue: move try_to_grab_pending() upwards Tejun Heo
2012-07-27 23:55 ` [PATCH 09/15] workqueue: introduce WORK_OFFQ_FLAG_* Tejun Heo
2012-07-27 23:55 ` [PATCH 10/15] workqueue: factor out __queue_delayed_work() from queue_delayed_work_on() Tejun Heo
2012-07-27 23:55 ` [PATCH 11/15] workqueue: reorganize try_to_grab_pending() and __cancel_timer_work() Tejun Heo
2012-07-27 23:55 ` [PATCH 12/15] workqueue: mark a work item being canceled as such Tejun Heo
2012-07-30 20:11 ` [PATCH v2 " Tejun Heo
2012-07-27 23:55 ` [PATCH 13/15] workqueue: implement mod_delayed_work[_on]() Tejun Heo
2012-07-27 23:55 ` [PATCH 14/15] workqueue: use mod_delayed_work() instead of cancel + queue Tejun Heo
2012-07-28 1:05 ` Henrique de Moraes Holschuh
2012-07-28 1:28 ` Dmitry Torokhov
2012-07-29 20:55 ` Anton Vorontsov
2012-07-31 17:55 ` [PATCH v2 " Tejun Heo
2012-07-27 23:55 ` [PATCH 15/15] workqueue: deprecate __cancel_delayed_work() Tejun Heo
2012-07-31 13:05 ` Tomi Valkeinen
2012-07-31 17:11 ` Tejun Heo [this message]
2012-07-31 17:51 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120731171146.GA21292@google.com \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cbou@mail.ru \
--cc=davem@davemloft.net \
--cc=dougthompson@xmission.com \
--cc=ibm-acpi@hmh.eng.br \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mingo@redhat.com \
--cc=padovan@profusion.mobi \
--cc=peterz@infradead.org \
--cc=roland@kernel.org \
--cc=rui.zhang@intel.com \
--cc=tomi.valkeinen@ti.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).