From: Marcelo Tosatti <mtosatti@redhat.com>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Avi Kivity <avi@redhat.com>, Gleb Natapov <gleb@redhat.com>,
Joerg Roedel <joerg.roedel@amd.com>,
Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [RFC PATCH] KVM: Only print vcpu_unimpl when DEBUG is set
Date: Wed, 1 Aug 2012 00:19:30 -0300 [thread overview]
Message-ID: <20120801031930.GB31711@amt.cnet> (raw)
In-Reply-To: <20120726122248.GA252@x4>
On Thu, Jul 26, 2012 at 02:22:48PM +0200, Markus Trippelsdorf wrote:
> Every time I start qemu-kvm on my system the following line is added to
> the syslog:
>
> vcpu0 unhandled rdmsr: 0xc0010001
>
> AFAICS all calls to vcpu_unimpl only contain debugging info with little
> or no value for the end user.
>
> Wouldn't something like the following patch make sense?
>
> Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
It could be useful for debugging (but then lots of other things could).
Anyone has a use for this?
> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index b70b48b..6bd816f 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -321,7 +321,7 @@ struct kvm {
> #define kvm_debug(fmt, ...) \
> pr_debug("kvm [%i]: " fmt, task_pid_nr(current), ## __VA_ARGS__)
> #define kvm_pr_unimpl(fmt, ...) \
> - pr_err_ratelimited("kvm [%i]: " fmt, \
> + pr_debug_ratelimited("kvm [%i]: " fmt, \
> task_tgid_nr(current), ## __VA_ARGS__)
>
> /* The guest did something we don't support. */
>
> --
> Markus
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-08-01 3:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 12:22 [RFC PATCH] KVM: Only print vcpu_unimpl when DEBUG is set Markus Trippelsdorf
2012-08-01 3:19 ` Marcelo Tosatti [this message]
2012-08-01 8:41 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120801031930.GB31711@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox