From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754125Ab2HAG7L (ORCPT ); Wed, 1 Aug 2012 02:59:11 -0400 Received: from zoneX.GCU-Squad.org ([194.213.125.0]:2322 "EHLO services.gcu-squad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751360Ab2HAG7J (ORCPT ); Wed, 1 Aug 2012 02:59:09 -0400 Date: Wed, 1 Aug 2012 08:58:57 +0200 From: Jean Delvare To: Greg KH Cc: LKML Subject: Re: [PATCH v2] platform: Add support for automatic device IDs Message-ID: <20120801085857.0304cf0a@endymion.delvare> In-Reply-To: <20120731235059.GA5702@kroah.com> References: <20120727221459.144855ba@endymion.delvare> <20120731235059.GA5702@kroah.com> X-Mailer: Claws Mail 3.7.10 (GTK+ 2.24.7; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 31 Jul 2012 16:50:59 -0700, Greg KH wrote: > On Fri, Jul 27, 2012 at 10:14:59PM +0200, Jean Delvare wrote: > > Right now we have support for explicit platform device IDs, as well as > > ID-less platform devices when a given device type can only have one > > instance. However there are cases where multiple instances of a device > > type can exist, and their IDs aren't (and can't be) known in advance > > and do not matter. In that case we need automatic device IDs to avoid > > device name collisions. > > > > I am using magic ID value -2 (PLATFORM_DEVID_AUTO) for this, similar > > to -1 for ID-less devices. The automatically allocated device IDs are > > global (to avoid an additional per-driver cost.) We keep note that the > > ID was automatically allocated so that it can be freed later. > > > > Note that we also restore the ID to PLATFORM_DEVID_AUTO on error and > > device deletion, to avoid avoid unexpected behavior on retry. I don't > > really expect retries on platform device addition, but better safe > > than sorry. > > > > Signed-off-by: Jean Delvare > > Cc: Greg Kroah-Hartman > > Looks sane to me, want me to queue it up for 3.7? Yes, please! Thanks, -- Jean Delvare