* [PATCH] pwm: Add missing static storage class specifiers in core.c file
@ 2012-08-02 7:02 Sachin Kamat
2012-08-02 7:35 ` Thierry Reding
2012-08-09 5:49 ` Thierry Reding
0 siblings, 2 replies; 3+ messages in thread
From: Sachin Kamat @ 2012-08-02 7:02 UTC (permalink / raw)
To: linux-kernel; +Cc: thierry.reding, sachin.kamat, patches
Fixes the following sparse warnings:
drivers/pwm/core.c:152:6: warning:
symbol 'of_pwmchip_add' was not declared. Should it be static?
drivers/pwm/core.c:165:6: warning:
symbol 'of_pwmchip_remove' was not declared. Should it be static?
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/pwm/core.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index ecb7690..4a8bdfa 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -149,7 +149,7 @@ static struct pwm_device *of_pwm_simple_xlate(struct pwm_chip *pc,
return pwm;
}
-void of_pwmchip_add(struct pwm_chip *chip)
+static void of_pwmchip_add(struct pwm_chip *chip)
{
if (!chip->dev || !chip->dev->of_node)
return;
@@ -162,7 +162,7 @@ void of_pwmchip_add(struct pwm_chip *chip)
of_node_get(chip->dev->of_node);
}
-void of_pwmchip_remove(struct pwm_chip *chip)
+static void of_pwmchip_remove(struct pwm_chip *chip)
{
if (chip->dev && chip->dev->of_node)
of_node_put(chip->dev->of_node);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pwm: Add missing static storage class specifiers in core.c file
2012-08-02 7:02 [PATCH] pwm: Add missing static storage class specifiers in core.c file Sachin Kamat
@ 2012-08-02 7:35 ` Thierry Reding
2012-08-09 5:49 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2012-08-02 7:35 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel, patches
[-- Attachment #1: Type: text/plain, Size: 406 bytes --]
On Thu, Aug 02, 2012 at 12:32:42PM +0530, Sachin Kamat wrote:
> Fixes the following sparse warnings:
> drivers/pwm/core.c:152:6: warning:
> symbol 'of_pwmchip_add' was not declared. Should it be static?
> drivers/pwm/core.c:165:6: warning:
> symbol 'of_pwmchip_remove' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pwm: Add missing static storage class specifiers in core.c file
2012-08-02 7:02 [PATCH] pwm: Add missing static storage class specifiers in core.c file Sachin Kamat
2012-08-02 7:35 ` Thierry Reding
@ 2012-08-09 5:49 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2012-08-09 5:49 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel, patches
[-- Attachment #1: Type: text/plain, Size: 501 bytes --]
On Thu, Aug 02, 2012 at 12:32:42PM +0530, Sachin Kamat wrote:
> Fixes the following sparse warnings:
> drivers/pwm/core.c:152:6: warning:
> symbol 'of_pwmchip_add' was not declared. Should it be static?
> drivers/pwm/core.c:165:6: warning:
> symbol 'of_pwmchip_remove' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/pwm/core.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-08-09 5:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-02 7:02 [PATCH] pwm: Add missing static storage class specifiers in core.c file Sachin Kamat
2012-08-02 7:35 ` Thierry Reding
2012-08-09 5:49 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).