* [PATCH] i2c: muxes: fix build break
@ 2012-08-02 9:12 Venu Byravarasu
2012-08-02 9:53 ` Jean Delvare
0 siblings, 1 reply; 2+ messages in thread
From: Venu Byravarasu @ 2012-08-02 9:12 UTC (permalink / raw)
To: swarren, rob.herring, linus.walleij; +Cc: vbyravarasu, linux-i2c, linux-kernel
Seems a new parameter is added to i2c_add_mux_adapter().
All its references, except for the one present in
i2c-mux-pinctrl.c, were updated.
As this is causing build break, pushing current patch to fix it.
Signed-off-by: Venu Byravarasu <vbyravarasu@nvidia.com>
---
drivers/i2c/muxes/i2c-mux-pinctrl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-pinctrl.c b/drivers/i2c/muxes/i2c-mux-pinctrl.c
index 46a6697..5f097f3 100644
--- a/drivers/i2c/muxes/i2c-mux-pinctrl.c
+++ b/drivers/i2c/muxes/i2c-mux-pinctrl.c
@@ -221,7 +221,7 @@ static int __devinit i2c_mux_pinctrl_probe(struct platform_device *pdev)
(mux->pdata->base_bus_num + i) : 0;
mux->busses[i] = i2c_add_mux_adapter(mux->parent, &pdev->dev,
- mux, bus, i,
+ mux, bus, i, 0,
i2c_mux_pinctrl_select,
deselect);
if (!mux->busses[i]) {
--
1.7.1.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] i2c: muxes: fix build break
2012-08-02 9:12 [PATCH] i2c: muxes: fix build break Venu Byravarasu
@ 2012-08-02 9:53 ` Jean Delvare
0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2012-08-02 9:53 UTC (permalink / raw)
To: Venu Byravarasu
Cc: swarren, rob.herring, linus.walleij, linux-i2c, linux-kernel
Hi Venu,
On Thu, 2 Aug 2012 14:42:17 +0530, Venu Byravarasu wrote:
> Seems a new parameter is added to i2c_add_mux_adapter().
> All its references, except for the one present in
> i2c-mux-pinctrl.c, were updated.
> As this is causing build break, pushing current patch to fix it.
Thanks for the heads up. When I wrote the patch adding the parameter,
the i2c-mux-pinctrl driver wasn't upstream yet, that's why I missed it.
>
> Signed-off-by: Venu Byravarasu <vbyravarasu@nvidia.com>
> ---
> drivers/i2c/muxes/i2c-mux-pinctrl.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/muxes/i2c-mux-pinctrl.c b/drivers/i2c/muxes/i2c-mux-pinctrl.c
> index 46a6697..5f097f3 100644
> --- a/drivers/i2c/muxes/i2c-mux-pinctrl.c
> +++ b/drivers/i2c/muxes/i2c-mux-pinctrl.c
> @@ -221,7 +221,7 @@ static int __devinit i2c_mux_pinctrl_probe(struct platform_device *pdev)
> (mux->pdata->base_bus_num + i) : 0;
>
> mux->busses[i] = i2c_add_mux_adapter(mux->parent, &pdev->dev,
> - mux, bus, i,
> + mux, bus, i, 0,
> i2c_mux_pinctrl_select,
> deselect);
> if (!mux->busses[i]) {
As the problematic patch isn't upstream yet, I've simply folded the
above into it:
http://khali.linux-fr.org/devel/linux-3/jdelvare-i2c/i2c-mux-support-class.patch
Thanks again,
--
Jean Delvare
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-02 9:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-02 9:12 [PATCH] i2c: muxes: fix build break Venu Byravarasu
2012-08-02 9:53 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).