From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: Liam Girdwood <lrg@ti.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: core: Add intermediate cast to uintptr_t before casting to pointer
Date: Thu, 2 Aug 2012 19:00:51 +0100 [thread overview]
Message-ID: <20120802180051.GI4537@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1343750888.5463.5.camel@phoenix>
On Wed, Aug 01, 2012 at 12:08:08AM +0800, Axel Lin wrote:
> 於 二，2012-07-31 於 16:41 +0100，Mark Brown 提到：
> > So the above cast probably isn't right... you shouldn't need a double
> > cast here.
> The issue of original warning is: ( I compile the kernel on x86_64 )
> warning: cast to pointer from integer of different size
> What this patch does is:
> cast best_val to uintptr_t, which is an unsigned integer large enough to
> hold a void* pointer.
> And then cast it to (void *).
> Thus I did (void *)(uintptr_t)best_val.
Perhaps we need a temporary variable here. The double cast just looks
too horrible.
next prev parent reply other threads:[~2012-08-02 18:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-29 23:47 [PATCH] regulator: core: Add intermediate cast to uintptr_t before casting to pointer Axel Lin
2012-07-30 15:33 ` Mark Brown
2012-07-31 2:21 ` Axel Lin
2012-07-31 15:41 ` Mark Brown
2012-07-31 16:08 ` Axel Lin
2012-08-02 18:00 ` Mark Brown [this message]
2012-08-05 16:10 ` Axel Lin
2012-08-06 14:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120802180051.GI4537@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).