* [PATCH 1/2] iommu: Include linux/types.h
@ 2012-07-25 14:24 Thierry Reding
2012-07-25 14:24 ` [PATCH 2/2] iommu: Include linux/notifier.h Thierry Reding
2012-08-03 14:07 ` [PATCH 1/2] iommu: Include linux/types.h Joerg Roedel
0 siblings, 2 replies; 5+ messages in thread
From: Thierry Reding @ 2012-07-25 14:24 UTC (permalink / raw)
To: Joerg Roedel; +Cc: iommu, linux-kernel
The linux/iommu.h header uses types defined in linux/types.h but doesn't
include it.
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
---
include/linux/iommu.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index a71df92..9cbcc6a 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -20,6 +20,7 @@
#define __LINUX_IOMMU_H
#include <linux/errno.h>
+#include <linux/types.h>
#define IOMMU_READ (1)
#define IOMMU_WRITE (2)
--
1.7.11.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] iommu: Include linux/notifier.h
2012-07-25 14:24 [PATCH 1/2] iommu: Include linux/types.h Thierry Reding
@ 2012-07-25 14:24 ` Thierry Reding
2012-08-03 14:08 ` Joerg Roedel
2012-08-03 14:07 ` [PATCH 1/2] iommu: Include linux/types.h Joerg Roedel
1 sibling, 1 reply; 5+ messages in thread
From: Thierry Reding @ 2012-07-25 14:24 UTC (permalink / raw)
To: Joerg Roedel; +Cc: iommu, linux-kernel
The linux/iommu.h header uses types defined in linux/notifier.h but
doesn't include it.
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
---
include/linux/iommu.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index 9cbcc6a..4f64020 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -20,6 +20,7 @@
#define __LINUX_IOMMU_H
#include <linux/errno.h>
+#include <linux/notifier.h>
#include <linux/types.h>
#define IOMMU_READ (1)
--
1.7.11.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] iommu: Include linux/notifier.h
2012-07-25 14:24 ` [PATCH 2/2] iommu: Include linux/notifier.h Thierry Reding
@ 2012-08-03 14:08 ` Joerg Roedel
2012-08-03 14:26 ` Thierry Reding
0 siblings, 1 reply; 5+ messages in thread
From: Joerg Roedel @ 2012-08-03 14:08 UTC (permalink / raw)
To: Thierry Reding; +Cc: iommu, linux-kernel
On Wed, Jul 25, 2012 at 04:24:50PM +0200, Thierry Reding wrote:
> The linux/iommu.h header uses types defined in linux/notifier.h but
> doesn't include it.
>
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
Better than adding the header-file is to add a forward declaration for
struct notifier_block. I added a patch to iommu/fixes for this.
Thanks,
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] iommu: Include linux/notifier.h
2012-08-03 14:08 ` Joerg Roedel
@ 2012-08-03 14:26 ` Thierry Reding
0 siblings, 0 replies; 5+ messages in thread
From: Thierry Reding @ 2012-08-03 14:26 UTC (permalink / raw)
To: Joerg Roedel; +Cc: iommu, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 490 bytes --]
On Fri, Aug 03, 2012 at 04:08:26PM +0200, Joerg Roedel wrote:
> On Wed, Jul 25, 2012 at 04:24:50PM +0200, Thierry Reding wrote:
> > The linux/iommu.h header uses types defined in linux/notifier.h but
> > doesn't include it.
> >
> > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
>
> Better than adding the header-file is to add a forward declaration for
> struct notifier_block. I added a patch to iommu/fixes for this.
Yes, that would also work.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] iommu: Include linux/types.h
2012-07-25 14:24 [PATCH 1/2] iommu: Include linux/types.h Thierry Reding
2012-07-25 14:24 ` [PATCH 2/2] iommu: Include linux/notifier.h Thierry Reding
@ 2012-08-03 14:07 ` Joerg Roedel
1 sibling, 0 replies; 5+ messages in thread
From: Joerg Roedel @ 2012-08-03 14:07 UTC (permalink / raw)
To: Thierry Reding; +Cc: iommu, linux-kernel
On Wed, Jul 25, 2012 at 04:24:49PM +0200, Thierry Reding wrote:
> The linux/iommu.h header uses types defined in linux/types.h but doesn't
> include it.
>
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
Applied to iommu/fixes, thanks Thierry.
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-08-03 14:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-25 14:24 [PATCH 1/2] iommu: Include linux/types.h Thierry Reding
2012-07-25 14:24 ` [PATCH 2/2] iommu: Include linux/notifier.h Thierry Reding
2012-08-03 14:08 ` Joerg Roedel
2012-08-03 14:26 ` Thierry Reding
2012-08-03 14:07 ` [PATCH 1/2] iommu: Include linux/types.h Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox