Re: 3.6-rc1: twl4030 don't compile :(

[NeilBrown <neilb@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 960 bytes --]

On Fri, 03 Aug 2012 01:12:10 -0400 Chris Ball <cjb@laptop.org> wrote:

> Hi,
> 
> On Fri, Aug 03 2012, werner wrote:
> >   CC      drivers/power/twl4030_charger.o
> > drivers/power/twl4030_charger.c:248:12: error: invalid suffix "b1100"
> > on integer constant
> 
> drivers/power/twl4030_charger.c:
> #define TWL4030_BBSEL_3V0       0b0100
> #define TWL4030_BBSEL_3V1       0b1000
> #define TWL4030_BBSEL_3V2       0b1100
> 
> Werner, your gcc version is too old to support the 0b-prefixed binary
> constant syntax.  It was introduced in gcc-4.3.  The kernel compiles
> fine here, on gcc-4.7.
> 
> Neil Brown added this use of the 0b prefix in 210d4bc8a3128e3e61ac3b
> ("twl4030_charger: Add backup-battery charging").  Neil, I don't think
> we can use this syntax yet -- Documentation/Changes says that we still
> support from gcc-3.2 onwards.

I didn't realise that 0b... wasn't universal.
I'll submit a patch.

Thanks,
NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]