From: Dan Carpenter <dan.carpenter@oracle.com>
To: Devendra Naga <develkernel412222@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
"Veli-Pekka Peltola" <veli-pekka.peltola@bluegiga.com>,
"Mikko Virkkilä" <mikko.virkkila@bluegiga.com>,
"Riku Mettälä" <riku.mettala@bluegiga.com>,
"Lauri Hintsala" <Lauri.Hintsala@bluegiga.com>
Subject: Re: [PATCH 1/5] staging/csr: clean coding style in uf_start_thread
Date: Mon, 6 Aug 2012 16:55:56 +0300 [thread overview]
Message-ID: <20120806135556.GA9956@mwanda> (raw)
This was sent encoded as base64 which is awkward.
On Sat, Aug 04, 2012 at 01:01:38PM +0545, Devendra Naga wrote:
> - } else {
> - priv->bh_thread.prio = DEFAULT_PRIO;
> - }
> + } else
> + priv->bh_thread.prio = DEFAULT_PRIO;
Probably it's not worth resending if this is the only complaint, but
actually the original had that braces correct. If either side of
the if else statement gets uses curly braces then both sides should
use them.
regards,
dan carpenter
next reply other threads:[~2012-08-06 13:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 13:55 Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-04 7:16 [PATCH 1/5] staging/csr: clean coding style in uf_start_thread Devendra Naga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120806135556.GA9956@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Lauri.Hintsala@bluegiga.com \
--cc=devel@driverdev.osuosl.org \
--cc=develkernel412222@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikko.virkkila@bluegiga.com \
--cc=riku.mettala@bluegiga.com \
--cc=veli-pekka.peltola@bluegiga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox