From: Dan Carpenter <dan.carpenter@oracle.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] drivers/mfd: drop frees of devm allocated data
Date: Mon, 6 Aug 2012 17:05:16 +0300 [thread overview]
Message-ID: <20120806140515.GM4352@mwanda> (raw)
In-Reply-To: <1344099049-15212-2-git-send-email-Julia.Lawall@lip6.fr>
On Sat, Aug 04, 2012 at 06:50:45PM +0200, Julia Lawall wrote:
> diff --git a/drivers/mfd/88pm80x.c b/drivers/mfd/88pm80x.c
> index cd0bf52..2bd090e 100644
> --- a/drivers/mfd/88pm80x.c
> +++ b/drivers/mfd/88pm80x.c
> @@ -45,17 +45,14 @@ int __devinit pm80x_init(struct i2c_client *client,
>
> map = devm_regmap_init_i2c(client, &pm80x_regmap_config);
> if (IS_ERR(map)) {
> - ret = PTR_ERR(map);
> dev_err(&client->dev, "Failed to allocate register map: %d\n",
> ret);
^^^
The ret = PTR_ERR(map); is still needed for the error message.
> - goto err_regmap_init;
> + return PTR_ERR(map);
> }
regards,
dan carpenter
next prev parent reply other threads:[~2012-08-06 14:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-04 16:50 [PATCH 2/6] drivers/mfd: drop frees of devm allocated data Julia Lawall
2012-08-06 14:05 ` Dan Carpenter [this message]
2012-08-06 19:57 ` Julia.Lawall
2012-08-13 19:36 ` Julia Lawall
2012-09-16 23:24 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120806140515.GM4352@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Julia.Lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox