From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756445Ab2HFOL3 (ORCPT ); Mon, 6 Aug 2012 10:11:29 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:53278 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756425Ab2HFOL0 (ORCPT ); Mon, 6 Aug 2012 10:11:26 -0400 Date: Mon, 6 Aug 2012 15:11:21 +0100 From: Lee Jones To: Linus Walleij Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, arnd@arndb.de, w.sang@pengutronix.de, srinidhi.kasagar@stericsson.com, linux-i2c@vger.kernel.org Subject: Re: [PATCH 1/1] i2c: Add default configuration into the Nomadik I2C driver. Message-ID: <20120806141120.GE10524@gmail.com> References: <1344255947-10062-1-git-send-email-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 06, 2012 at 04:00:04PM +0200, Linus Walleij wrote: > On Mon, Aug 6, 2012 at 2:25 PM, Lee Jones wrote: > > > At this moment in time there is only one known configuration for the > > Nomadik I2C driver. By not holding that configuration in the driver > > adds some unnecessary overhead in platform code. The configuration > > as already been removed from platform code, this patch checks for any > > over-riding configurations. If there aren't any, the default is used. > > > > Cc: linux-i2c@vger.kernel.org > > Acked-by: srinidhi kasagar > > Acked-by: Linus Walleij > > Signed-off-by: Lee Jones > > This still does not apply for me on v3.6-rc1 what did you base > this patch on? > > Applying: i2c: Add default configuration into the Nomadik I2C driver. > error: patch failed: drivers/i2c/busses/i2c-nomadik.c:899 > error: drivers/i2c/busses/i2c-nomadik.c: patch does not apply > Patch failed at 0001 i2c: Add default configuration into the Nomadik I2C driver. > When you have resolved this problem run "git am --resolved". > If you would prefer to skip this patch, instead run "git am --skip". > To restore the original branch and stop patching run "git am --abort". Ah, my mistake. I'll rebase to latest and re-submit. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog