* [PATCH] Bluetooth: Another vendor specific ID for BCM20702A0 [0a5c:21f1] @ 2012-07-27 21:21 Michal Marek 2012-07-27 23:29 ` Marcel Holtmann 0 siblings, 1 reply; 5+ messages in thread From: Michal Marek @ 2012-07-27 21:21 UTC (permalink / raw) To: linux-bluetooth; +Cc: linux-kernel Bus 002 Device 003: ID 0a5c:21f1 Broadcom Corp. Device Descriptor: bLength 18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass 255 Vendor Specific Class bDeviceSubClass 1 bDeviceProtocol 1 bMaxPacketSize0 64 idVendor 0x0a5c Broadcom Corp. idProduct 0x21f1 bcdDevice 1.12 iManufacturer 1 Broadcom Corp iProduct 2 BCM20702A0 iSerial 3 9CB70DCFF833 bNumConfigurations 1 Signed-off-by: Michal Marek <mmarek@suse.cz> --- drivers/bluetooth/btusb.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index e272214..5748b15 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -97,6 +97,7 @@ static struct usb_device_id btusb_table[] = { { USB_DEVICE(0x0a5c, 0x21e3) }, { USB_DEVICE(0x0a5c, 0x21e6) }, { USB_DEVICE(0x0a5c, 0x21e8) }, + { USB_DEVICE(0x0a5c, 0x21f1) }, { USB_DEVICE(0x0a5c, 0x21f3) }, { USB_DEVICE(0x413c, 0x8197) }, -- 1.7.3.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Bluetooth: Another vendor specific ID for BCM20702A0 [0a5c:21f1] 2012-07-27 21:21 [PATCH] Bluetooth: Another vendor specific ID for BCM20702A0 [0a5c:21f1] Michal Marek @ 2012-07-27 23:29 ` Marcel Holtmann 2012-07-31 13:47 ` [PATCH v2] " Michal Marek 0 siblings, 1 reply; 5+ messages in thread From: Marcel Holtmann @ 2012-07-27 23:29 UTC (permalink / raw) To: Michal Marek; +Cc: linux-bluetooth, linux-kernel Hi Michael, > Bus 002 Device 003: ID 0a5c:21f1 Broadcom Corp. > Device Descriptor: > bLength 18 > bDescriptorType 1 > bcdUSB 2.00 > bDeviceClass 255 Vendor Specific Class > bDeviceSubClass 1 > bDeviceProtocol 1 > bMaxPacketSize0 64 > idVendor 0x0a5c Broadcom Corp. > idProduct 0x21f1 > bcdDevice 1.12 > iManufacturer 1 Broadcom Corp > iProduct 2 BCM20702A0 > iSerial 3 9CB70DCFF833 > bNumConfigurations 1 as usual include /sys/kernel/debug/usb/devices details for this device. I want the full set of endpoint descriptors in a simple compact format in the commit messages for reference. Regards Marcel ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] Bluetooth: Another vendor specific ID for BCM20702A0 [0a5c:21f1] 2012-07-27 23:29 ` Marcel Holtmann @ 2012-07-31 13:47 ` Michal Marek 2012-08-06 18:40 ` Gustavo Padovan 0 siblings, 1 reply; 5+ messages in thread From: Michal Marek @ 2012-07-31 13:47 UTC (permalink / raw) To: linux-bluetooth, marcel; +Cc: linux-kernel T: Bus=02 Lev=02 Prnt=02 Port=01 Cnt=01 Dev#= 3 Spd=12 MxCh= 0 D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=0a5c ProdID=21f1 Rev= 1.12 S: Manufacturer=Broadcom Corp S: Product=BCM20702A0 S: SerialNumber=9CB70DCFF833 C:* #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr= 0mA I:* If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms I:* If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms I: If#= 1 Alt= 1 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms I: If#= 1 Alt= 2 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms I: If#= 1 Alt= 3 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms I: If#= 1 Alt= 4 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms I: If#= 1 Alt= 5 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms I:* If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) E: Ad=84(I) Atr=02(Bulk) MxPS= 32 Ivl=0ms E: Ad=04(O) Atr=02(Bulk) MxPS= 32 Ivl=0ms I:* If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none) Signed-off-by: Michal Marek <mmarek@suse.cz> --- drivers/bluetooth/btusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index e272214..5748b15 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -97,6 +97,7 @@ static struct usb_device_id btusb_table[] = { { USB_DEVICE(0x0a5c, 0x21e3) }, { USB_DEVICE(0x0a5c, 0x21e6) }, { USB_DEVICE(0x0a5c, 0x21e8) }, + { USB_DEVICE(0x0a5c, 0x21f1) }, { USB_DEVICE(0x0a5c, 0x21f3) }, { USB_DEVICE(0x413c, 0x8197) }, -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] Bluetooth: Another vendor specific ID for BCM20702A0 [0a5c:21f1] 2012-07-31 13:47 ` [PATCH v2] " Michal Marek @ 2012-08-06 18:40 ` Gustavo Padovan 2012-08-08 8:37 ` Michal Marek 0 siblings, 1 reply; 5+ messages in thread From: Gustavo Padovan @ 2012-08-06 18:40 UTC (permalink / raw) To: Michal Marek; +Cc: linux-bluetooth, marcel, linux-kernel Hi Michal, * Michal Marek <mmarek@suse.cz> [2012-07-31 15:47:34 +0200]: > T: Bus=02 Lev=02 Prnt=02 Port=01 Cnt=01 Dev#= 3 Spd=12 MxCh= 0 > D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=0a5c ProdID=21f1 Rev= 1.12 > S: Manufacturer=Broadcom Corp > S: Product=BCM20702A0 > S: SerialNumber=9CB70DCFF833 > C:* #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr= 0mA > I:* If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb > E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms > E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms > E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms > I:* If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb > E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms > E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms > I: If#= 1 Alt= 1 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb > E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms > E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms > I: If#= 1 Alt= 2 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb > E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms > E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms > I: If#= 1 Alt= 3 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb > E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms > E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms > I: If#= 1 Alt= 4 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb > E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms > E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms > I: If#= 1 Alt= 5 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb > E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms > E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms > I:* If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > E: Ad=84(I) Atr=02(Bulk) MxPS= 32 Ivl=0ms > E: Ad=04(O) Atr=02(Bulk) MxPS= 32 Ivl=0ms > I:* If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none) > > Signed-off-by: Michal Marek <mmarek@suse.cz> > --- > drivers/bluetooth/btusb.c | 1 + > 1 file changed, 1 insertion(+) Can you try the following patch on 3.6-rc1? It should fix this by matching vendor and inteface info. Gustavo --- Author: Gustavo Padovan <gustavo.padovan@collabora.co.uk> Date: Mon Aug 6 15:36:49 2012 -0300 Bluetooth: Use USB_VENDOR_AND_INTERFACE_INFO() for Broadcom devices Many Broadcom devices has a vendor specific devices class, with this rule we match all existent and future controllers with this behavior. Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index cef3bac..504231e 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -104,6 +104,9 @@ static struct usb_device_id btusb_table[] = { /* Foxconn - Hon Hai */ { USB_DEVICE(0x0489, 0xe033) }, + /*Broadcom devices with vendor specific id */ + { USB_VENDOR_AND_INTERFACE_INFO(0x0a5c, 0xff, 0x01, 0x01) }, + { } /* Terminating entry */ }; ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] Bluetooth: Another vendor specific ID for BCM20702A0 [0a5c:21f1] 2012-08-06 18:40 ` Gustavo Padovan @ 2012-08-08 8:37 ` Michal Marek 0 siblings, 0 replies; 5+ messages in thread From: Michal Marek @ 2012-08-08 8:37 UTC (permalink / raw) To: Gustavo Padovan, linux-bluetooth, marcel, linux-kernel, John Hommel On 6.8.2012 20:40, Gustavo Padovan wrote: > Author: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > Date: Mon Aug 6 15:36:49 2012 -0300 > > Bluetooth: Use USB_VENDOR_AND_INTERFACE_INFO() for Broadcom devices > > Many Broadcom devices has a vendor specific devices class, with this rule > we match all existent and future controllers with this behavior. > > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > index cef3bac..504231e 100644 > --- a/drivers/bluetooth/btusb.c > +++ b/drivers/bluetooth/btusb.c > @@ -104,6 +104,9 @@ static struct usb_device_id btusb_table[] = { > /* Foxconn - Hon Hai */ > { USB_DEVICE(0x0489, 0xe033) }, > > + /*Broadcom devices with vendor specific id */ > + { USB_VENDOR_AND_INTERFACE_INFO(0x0a5c, 0xff, 0x01, 0x01) }, Hi Gustavo, Yes, this works. Well, I don't posses the card personally, but a helpful person at HP confirmed that the btusb driver with this patch works with the new card. So you can add Tested-by: John Hommel <john.hommel@hp.com> BTW, the following ID can also be removed after adding the above match: { USB_DEVICE(0x0a5c, 0x21e1) }, { USB_DEVICE(0x0a5c, 0x21e3) }, { USB_DEVICE(0x0a5c, 0x21e6) }, { USB_DEVICE(0x0a5c, 0x21e8) }, { USB_DEVICE(0x0a5c, 0x21f3) }, Thanks, Michal ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-08-08 8:38 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-07-27 21:21 [PATCH] Bluetooth: Another vendor specific ID for BCM20702A0 [0a5c:21f1] Michal Marek 2012-07-27 23:29 ` Marcel Holtmann 2012-07-31 13:47 ` [PATCH v2] " Michal Marek 2012-08-06 18:40 ` Gustavo Padovan 2012-08-08 8:37 ` Michal Marek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox