Re: [PATCH 0/5] mfd: replace IORESOURCE_IO by IORESOURCE_MEM

Mark Brown
2012-08-06T22:00:35Z

On Mon, Aug 06, 2012 at 10:31:24PM +0100, Russell King wrote:

> So, the fact that platform devices will get any resource marked
> IORESOURCE_IO registered against ioport_resource isn't a problem
> then...

This is what providing a separate parent to ensure they're in a
different tree is there to fix.

> Anyway, given that this thread is broken, there's no way for me to find
> out what the _original_ issue is that you're talking about. So I'm going
> to guess that it's come up because we're out of IORESOURCE bits.

No, that's not it. What's happened is that Haojian has posted some
patching changing all the _IO resources to _MEM in the Marvell PMIC
drivers, I think because you yelled at him for using _IO when he
reported that the changes in ioport_resource broke things a few releases
ago. Obviously this doesn't achieve a huge amount, it's a misplaced
cleanup.

> So, if we made this a numeric index, then we have 32 resource types
> to deal with, and no need to bugger around with re-using an existing
> type for something else.

This seems sensible, and I'm sure if that change were made people would
be delighed to use new resource types, but like I say nobody who's
motivated to do anything here seems to have the time to do anything
about it.

Whoever looks at this would need to do some detective work, it does seem
like there must have been a reason to use a bitmask here...