From: Greg KH <gregkh@linuxfoundation.org>
To: Yann Cantin <yann.cantin@laposte.net>
Cc: linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC ebeam PATCH v3 1/2] hid: Blacklist new eBeam classic device
Date: Mon, 6 Aug 2012 14:43:40 -0700 [thread overview]
Message-ID: <20120806214340.GA30355@kroah.com> (raw)
In-Reply-To: <1344288104-20731-2-git-send-email-yann.cantin@laposte.net>
On Mon, Aug 06, 2012 at 11:21:43PM +0200, Yann Cantin wrote:
>
> Signed-off-by: Yann Cantin <yann.cantin@laposte.net>
> ---
> drivers/hid/hid-core.c | 3 +++
> drivers/hid/hid-ids.h | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 60ea284..b1ed8ee 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -1908,6 +1908,9 @@ static const struct hid_device_id hid_ignore_list[] = {
> { HID_USB_DEVICE(USB_VENDOR_ID_DELORME, USB_DEVICE_ID_DELORME_EM_LT20) },
> { HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, 0x0004) },
> { HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, 0x000a) },
> +#if defined(CONFIG_INPUT_EBEAM_USB)
> + { HID_USB_DEVICE(USB_VENDOR_ID_EFI, USB_DEVICE_ID_EFI_CLASSIC) },
> +#endif
Why is this #if in here? Just always do it, how could it not be
defined?
greg k-h
next prev parent reply other threads:[~2012-08-06 21:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 21:21 [RFC ebeam PATCH v3 0/2] Yann Cantin
2012-08-06 21:21 ` [RFC ebeam PATCH v3 1/2] hid: Blacklist new eBeam classic device Yann Cantin
2012-08-06 21:43 ` Greg KH [this message]
2012-08-06 22:07 ` Dmitry Torokhov
2012-08-07 1:21 ` Yann Cantin
2012-08-07 1:45 ` Dmitry Torokhov
2012-08-07 8:10 ` Yann Cantin
2012-08-06 21:21 ` [RFC ebeam PATCH v3 2/2] input: misc: New USB eBeam input driver Yann Cantin
2012-08-06 21:43 ` Greg KH
2012-08-07 0:56 ` Yann Cantin
2012-08-07 1:43 ` Dmitry Torokhov
2012-08-07 7:59 ` Yann Cantin
2012-08-06 21:44 ` [RFC ebeam PATCH v3 0/2] Greg KH
2012-08-06 22:09 ` Dmitry Torokhov
2012-08-07 1:45 ` Yann Cantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120806214340.GA30355@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=yann.cantin@laposte.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox