Re: [RFC ebeam PATCH v3 0/2]

Dmitry Torokhov
2012-08-06T22:09:18Z

On Monday, August 06, 2012 02:44:23 PM Greg KH wrote:
> On Mon, Aug 06, 2012 at 11:21:42PM +0200, Yann Cantin wrote:
> > Hi,
> >
> > New USB input driver for eBeam devices.
> >
> > Currently, only the Luidia eBeam classic projection model is supported.
> > Edge model and a NEC interactive video-projector support planned for the
> > end of the mounth.
> >
> > Patch 1 to blacklist the device for hid generic-usb.
> >
> > Patch 2 is the actual driver.
> >
> > Changes from previous :
> > - switch to div64_s64 for portable 64/64-bits divisions

Do you really need this much precision? It will be slower on 32 bits..

> > - some cosmetics in device name
> > - unused include and def removed
> > - variables name changes for readability
> >
> > Pending issues :
> >
> > - sysfs custom files : need to pass 13 parameters for calibration :
> > choice is between lots of simply-handled, or few with a big sscanf.
>
> sysfs is "one value per file", so use lots of different files please.

This is kind of a "one value" though - it is a transformation matrix.
Maybe switch it to binary - 9 s32?

--
Dmitry