Re: [RFC ebeam PATCH v3 1/2] hid: Blacklist new eBeam classic device

Greg KH
2012-08-06T21:43:45Z

On Mon, Aug 06, 2012 at 11:21:43PM +0200, Yann Cantin wrote:
>
> Signed-off-by: Yann Cantin <yann.cantin@laposte.net>
> ---
> drivers/hid/hid-core.c | 3 +++
> drivers/hid/hid-ids.h | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 60ea284..b1ed8ee 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -1908,6 +1908,9 @@ static const struct hid_device_id hid_ignore_list[] = {
> { HID_USB_DEVICE(USB_VENDOR_ID_DELORME, USB_DEVICE_ID_DELORME_EM_LT20) },
> { HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, 0x0004) },
> { HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, 0x000a) },
> +#if defined(CONFIG_INPUT_EBEAM_USB)
> + { HID_USB_DEVICE(USB_VENDOR_ID_EFI, USB_DEVICE_ID_EFI_CLASSIC) },
> +#endif

Why is this #if in here? Just always do it, how could it not be
defined?

greg k-h