From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org,
Laxman Dewangan <ldewangan@nvidia.com>,
Gyungoh Yoo <jack.yoo@maxim-ic.com>,
Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH] regulator: add MAX8907 driver
Date: Mon, 6 Aug 2012 22:47:24 +0100 [thread overview]
Message-ID: <20120806214724.GC26698@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <50203589.5020509@wwwdotorg.org>
On Mon, Aug 06, 2012 at 03:22:17PM -0600, Stephen Warren wrote:
> On 08/04/2012 04:19 AM, Mark Brown wrote:
> > I'm really not convinced it makes much sense to represent the backlight
> > driver current regulators as regulators, they only get used as part of
> > the backlight and are usually tightly coupled to their boosts.
> So you mean just completely remove any reference to WLED from the
> driver? There is a register to configure the current limit - do you not
> expect anything to ever need to set that in the kernel; do you expect
> the HW default to be correct, or the bootloader to set the desired value?
I'd expect it to be configured as part of configuring the overall
backlight, for an actual current regulator you're not setting a current
limit but rather a current which usually translates directly into a
brightness. As I say this will usually be done in conjunction with a
boost regulator.
prev parent reply other threads:[~2012-08-06 21:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 18:27 [PATCH] regulator: add MAX8907 driver Stephen Warren
2012-08-04 10:19 ` Mark Brown
2012-08-06 21:22 ` Stephen Warren
2012-08-06 21:47 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120806214724.GC26698@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=jack.yoo@maxim-ic.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox