From: Anton Vorontsov <cbouatmailru@gmail.com>
To: "Pallala, Ramakrishna" <ramakrishna.pallala@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] power_supply: Added support for power supply attribute sources
Date: Mon, 6 Aug 2012 21:41:43 -0700 [thread overview]
Message-ID: <20120807044143.GA20339@lizard> (raw)
In-Reply-To: <D854C92F57B1B347B57E531E78D05EAD1C31C9@BGSMSX102.gar.corp.intel.com>
On Fri, Jul 27, 2012 at 06:28:31PM +0000, Pallala, Ramakrishna wrote:
[...]
> > > Signed-off-by: Ramakrishna Pallala <ramakrishna.pallala@intel.com>
> > > ---
> > [...]
> > > +extern int power_supply_attributes_register(struct device *parent,
> > > + struct power_supply_attr_source *psy_attr);
> >
> > Can you please show some user of the new calls? If I understand correctly,
> > you're going to call these from sensing (ADC, or some
> > other) drivers, which would be very very wrong thing to do.
>
> I have submitted two patches, one on smb347_charger driver and one on max17042_battery driver
> to demonstrate the use of these API's.
>
> [PATCH] smb347_charger: Add support for battery power supply attributes registration
> [PATCH] max17042_battery: add support for battery STATUS and CHARGE_TYPE
Yeah, I noticed them, I'll review the whole approach tomorrow.
Thanks!
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
prev parent reply other threads:[~2012-08-07 4:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 15:17 [PATCH v2] power_supply: Added support for power supply attribute sources Ramakrishna Pallala
2012-07-26 17:04 ` Anton Vorontsov
2012-07-27 18:28 ` Pallala, Ramakrishna
2012-08-06 6:42 ` Pallala, Ramakrishna
2012-08-07 4:41 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120807044143.GA20339@lizard \
--to=cbouatmailru@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ramakrishna.pallala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox