Re: [PATCH RFT] regulator: ab8500: Set enable enable_time in regulator_desc

Linus Walleij
2012-08-06T15:50:13Z

On Mon, Aug 6, 2012 at 5:46 PM, Axel Lin <axel.lin@gmail.com> wrote:
> 2012/7/4 Mark Brown <broonie@opensource.wolfsonmicro.com>:
>> On Wed, Jul 04, 2012 at 10:31:45AM +0800, Axel Lin wrote:
>>> Signed-off-by: Axel Lin <axel.lin@gmail.com>
>>> ---
>>> Hi Linus,
>>> While working on this patch, I found in original code:
>>> ab8500_regulator_ops set enable_time callback to ab8500_regulator_enable_time,
>>> but does not set the delay in ab8500_regulator_info.
>>> I'm not sure the delay value is 0 for ab8500_regulator_ops, or the setting is
>>> just missing.
>>> Anyway, there is no behavior change by this patch.
>>
>> Surely if the delay is not set in info then it'll introduce a delay
>> which wasn't there before (but which may well be a bug fix)?
>
> Ping...
>
> Hi Linus,
> Any comments on this patch?

Looks good to me:
Acked-by: Linus Walleij <linus.walleij@linaro.org>

I need to check the proper rise times with the maintainers.

Yours,
Linus Walleij