public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: john stultz <johnstul@us.ibm.com>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Oleg Nesterov <oleg@redhat.com>
Subject: Re: rcu stalls seen with numasched_v2 patches applied.
Date: Tue, 7 Aug 2012 22:49:25 +0530	[thread overview]
Message-ID: <20120807171859.GB3850@linux.vnet.ibm.com> (raw)
In-Reply-To: <1344347568.27828.122.camel@twins>

* Peter Zijlstra <peterz@infradead.org> [2012-08-07 15:52:48]:

> On Tue, 2012-08-07 at 18:03 +0530, Srikar Dronamraju wrote:
> > Hi, 
> > 
> >  INFO: rcu_sched self-detected stall on CPU { 7}  (t=105182911 jiffies)
> >  Pid: 5173, comm: qpidd Tainted: G        W    3.5.0numasched_v2_020812+ #1
> >  Call Trace:
> >  <IRQ>  [<ffffffff810d4c7e>] rcu_check_callbacks+0x18e/0x650
> >  [<ffffffff81060918>] update_process_times+0x48/0x90
> >  [<ffffffff810a2a7e>] tick_sched_timer+0x6e/0xe0
> >  [<ffffffff810789a5>] __run_hrtimer+0x75/0x1a0
> >  [<ffffffff810a2a10>] ? tick_setup_sched_timer+0x100/0x100
> >  [<ffffffff810591cf>] ? __do_softirq+0x13f/0x240
> >  [<ffffffff81078d56>] hrtimer_interrupt+0xf6/0x240
> >  [<ffffffff814f0179>] smp_apic_timer_interrupt+0x69/0x99
> >  [<ffffffff814ef14a>] apic_timer_interrupt+0x6a/0x70
> >  <EOI>  [<ffffffff814e64b2>] ? _raw_spin_unlock_irqrestore+0x12/0x20
> >  [<ffffffff81082552>] sched_setnode+0x82/0xf0
> >  [<ffffffff8108bd38>] task_numa_work+0x1e8/0x240
> >  [<ffffffff81070c6c>] task_work_run+0x6c/0x80
> >  [<ffffffff81013984>] do_notify_resume+0x94/0xa0
> >  [<ffffffff814e6a6c>] retint_signal+0x48/0x8c
> 
> I haven't seen anything like that (obviously), but the one thing you can
> try is undo the optimization Oleg suggested and use a separate
> callback_head for the task_work and not reuse task_struct::rcu.
> 

Are you referring to this the commit 158e1645e (trim task_work: get rid of hlist)

I am also able to reproduce this on another 8 node machine too.

Just to update, I had to revert commit: b9403130a5  sched/cleanups: Add
load balance cpumask pointer to 'struct lb_env' so that your patches
apply cleanly. (I dont think this should have caused any problem.. but)

-- 
Thanks and Regards
Srikar


  reply	other threads:[~2012-08-07 18:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-07 12:33 rcu stalls seen with numasched_v2 patches applied Srikar Dronamraju
2012-08-07 13:52 ` Peter Zijlstra
2012-08-07 17:19   ` Srikar Dronamraju [this message]
2012-08-08 19:58     ` Peter Zijlstra
2012-08-10 16:24       ` Srikar Dronamraju
2012-08-13  7:51         ` Peter Zijlstra
2012-08-13  8:11           ` Peter Zijlstra
2012-08-16 17:16             ` Srikar Dronamraju
2012-08-17  5:23           ` Srikar Dronamraju
2012-08-07 17:08 ` John Stultz
2012-08-07 16:59   ` Srikar Dronamraju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120807171859.GB3850@linux.vnet.ibm.com \
    --to=srikar@linux.vnet.ibm.com \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox