From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH RFC] regulator: suppress printk if there is no real info
Date: Tue, 7 Aug 2012 19:16:42 +0100 [thread overview]
Message-ID: <20120807181642.GF16861@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120807181549.GF9888@pengutronix.de>
On Tue, Aug 07, 2012 at 08:15:49PM +0200, Uwe Kleine-König wrote:
> On Tue, Aug 07, 2012 at 07:10:22PM +0100, Mark Brown wrote:
> > > if (!buf[0])
> > > buf = "no parameters";
> > Yeah, having the log message for other regulators is helpful since
> > things often go boom after you mess with power but not so useful for
> > dummy.
> That's a +1 for which approach?
The above one which preserves the log message.
next prev parent reply other threads:[~2012-08-07 18:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 9:18 [PATCH RFC] regulator: suppress printk if there is no real info Uwe Kleine-König
2012-08-07 18:10 ` Mark Brown
2012-08-07 18:15 ` Uwe Kleine-König
2012-08-07 18:16 ` Mark Brown [this message]
2012-08-07 19:01 ` [PATCH v2] regulator: make the dummy regulator's print_constraint more helpful Uwe Kleine-König
2012-08-08 13:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120807181642.GF16861@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox