Re: [PATCH v2 21/23] xen: update xen_add_to_physmap interface

Stefano Stabellini
2012-08-08T17:23:18Z

On Tue, 7 Aug 2012, Konrad Rzeszutek Wilk wrote:
> On Mon, Aug 06, 2012 at 03:27:24PM +0100, Stefano Stabellini wrote:
> > Update struct xen_add_to_physmap to be in sync with Xen's version of the
> > structure.
> > The size field was introduced by:
> >
> > changeset: 24164:707d27fe03e7
> > user: Jean Guyader <jean.guyader@eu.citrix.com>
> > date: Fri Nov 18 13:42:08 2011 +0000
> > summary: mm: New XENMEM space, XENMAPSPACE_gmfn_range
> >
> > According to the comment:
> >
> > "This new field .size is located in the 16 bits padding between .domid
> > and .space in struct xen_add_to_physmap to stay compatible with older
> > versions."
> >
> > Changes in v2:
>
> Looks good. Let me take this as in my tree to prep it for Mukesh's patches.

OK.
Beware that patch #23 is going to modify xen_add_to_physmap again to
replace .size with a union.

> > - remove erroneous comment in the commit message.
> >
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > ---
> > include/xen/interface/memory.h | 3 +++
> > 1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/xen/interface/memory.h b/include/xen/interface/memory.h
> > index b5c3098..b66d04c 100644
> > --- a/include/xen/interface/memory.h
> > +++ b/include/xen/interface/memory.h
> > @@ -163,6 +163,9 @@ struct xen_add_to_physmap {
> > /* Which domain to change the mapping for. */
> > domid_t domid;
> >
> > + /* Number of pages to go through for gmfn_range */
> > + uint16_t size;
> > +
> > /* Source mapping space. */
> > #define XENMAPSPACE_shared_info 0 /* shared info page */
> > #define XENMAPSPACE_grant_table 1 /* grant table page */
> > --
> > 1.7.2.5
>