public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Wesley Miaw <wmiaw@netflix.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Will Drewry™" <w@google.com>, "msb@google.com" <msb@google.com>
Subject: Re: [PATCH] dm: verity support data device offset
Date: Tue, 7 Aug 2012 20:36:21 -0700	[thread overview]
Message-ID: <20120808033621.GA12743@kroah.com> (raw)
In-Reply-To: <66ADE819-D9DE-4A95-9B48-9C4B060CFB06@netflix.com>

On Wed, Aug 08, 2012 at 12:43:28AM +0000, Wesley Miaw wrote:
> I needed to add support for dm-verity with data that is offset into a block device. As part of this I found that the existing code did not compute the correct hash block index if the data_start might be non-zero. Here's a patch to add support for a data offset target parameter as well as a fix to the hash block index computation.
> 
> Patch and (hopefully proper) commit message below. Thanks.
> --
> Wesley Miaw
> 
> ============================================================
> 
> Add data device start block index to dm-verity target parameters to support verity targets where the data does not begin at sector 0 of the block device. Also fix the hash block index computation so it takes into account data offsets.

You forgot a "Signed-off-by:" line in the patch description here.  Take
a look at the kernel file, Documentation/SubmittingPatches for what this
means, and how to properly format the patch so it can be applied.

Also try to send the patch to the correct people who can review, and
(hopefully) apply it.  The tool, scripts/get_maintainer.pl can help you
out with that (hint, you didn't send it to anyone who could do anything
about it.)

Hope this helps,

greg k-h

      reply	other threads:[~2012-08-08  3:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-08  0:43 [PATCH] dm: verity support data device offset Wesley Miaw
2012-08-08  3:36 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120808033621.GA12743@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=msb@google.com \
    --cc=w@google.com \
    --cc=wmiaw@netflix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox