From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932285Ab2HHHf1 (ORCPT ); Wed, 8 Aug 2012 03:35:27 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:62815 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757762Ab2HHHfY (ORCPT ); Wed, 8 Aug 2012 03:35:24 -0400 Date: Wed, 8 Aug 2012 08:35:19 +0100 From: Lee Jones To: Mark Brown Cc: Dmitry Torokhov , linus.walleij@stericsson.com, arnd@arndb.de, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/1] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots Message-ID: <20120808073518.GA4728@gmail.com> References: <1344256323-10484-1-git-send-email-lee.jones@linaro.org> <20120806081915.GA4518@core.coreip.homeip.net> <20120806153750.GI10524@gmail.com> <20120806160226.GF29272@sirena.org.uk> <20120807170129.GA3759@gmail.com> <20120807170333.GV16861@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20120807170333.GV16861@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Restating my comment elsewhere... why do we even need to do this in > _get_virq() - I'd *really* expect this to be handled by the irq domain > code. > > Okay, so I've just spent a small amount of time looking at this. I think > > the best place for this would be in *_get_virq(), using the same logic that > > selected a *_legacy or *_linear domain in the first place. > I'd expect your driver to always pass a hwirq into _get_virq() here. I actually had this thought last night. (I really must learn to switch off in the evenings.) ;) That's even easier then. I'll make the changes and submit. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog