From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932486Ab2HHI2r (ORCPT <rfc822;w@1wt.eu>);
	Wed, 8 Aug 2012 04:28:47 -0400
Received: from moutng.kundenserver.de ([212.227.126.187]:61878 "EHLO
	moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932330Ab2HHI2o (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 8 Aug 2012 04:28:44 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH 1/1] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots
Date: Wed, 8 Aug 2012 08:28:35 +0000
User-Agent: KMail/1.12.2 (Linux/3.5.0; KDE/4.3.2; x86_64; ; )
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        linus.walleij@stericsson.com, linux-kernel@vger.kernel.org,
        linux-input@vger.kernel.org, STEricsson_nomadik_linux@list.st.com,
        linux-arm-kernel@lists.infradead.org
References: <20120807170333.GV16861@opensource.wolfsonmicro.com> <20120808080411.GB4728@gmail.com>
In-Reply-To: <20120808080411.GB4728@gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201208080828.35451.arnd@arndb.de>
X-Provags-ID: V02:K0:5JSkvR8VZKHB/thXNOVbsA7Sot2u257dhZtRLAPplfh
 gV63NG80I83KfdlpPaZdLhhPtiaIgJZqRPZ6IXLF3UN+7uXnPe
 s/L4uxsm0rf5N7txE7/Zw86v7HfWRyMPhOhUORys1Gg1DMzKPX
 HozGjTFs9x6T3uuE98kW0BUswr3wgiBSj4oYzMr4KjDfVgnZRo
 WLP9hXDZVVusZ88BHjvdbQt+epCGKdtPUbGIMTriz9R2HRNMaM
 zzAEnUljh4ezvadPb2DZ3KKfiRN/fEBj6dxohl7QdiNs7e80fB
 w2V/gCS3oTr4gUaTPD8Helur7Wckv+GN5vl6vL4Ygc0KXlobhE
 8Rw6BQQVspf68h+3C+Bg=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday 08 August 2012, Lee Jones wrote:
> Okay, actually this isn't so easy. Currently we have:
> 
> During DT boot:
>  - No platform data is passed, hence no IRQ base for AB8500 is either
>  - No IRQ base means we register a Linear IRQ Domain
>  - MFD sees there is no base and leaves the IRQ resource as a hwirq
>  - AB8500 child devices use *_get_virq() to convert the hwirq to a virq
> 
> During non-DT boot:
>  - Platform data is passed, which contains an IRQ base
>  - If an IRQ base is requested we use it to register a Legacy IRQ Domain
>  - MFD adds the IRQ base to the hwirq and registers it as a virq
>  - AB8500 child devices use *_get_virq() to convert virq to virq - ERROR
> 
> I guess my suggestion falls-back to placing logic in *_get_virq() to only
> call irq_create_mapping() when when !ab8500->irq_base.

In general, it seems easier to use the same domain type for both cases.
I don't think that MOP500_AB8500_VIR_GPIO_IRQ_BASE is used anywhere
else besides the .irq_base definition in board-mop500.c, so I would guess
that you can just remove that identifier and always use the linear
domain.

	Arnd