From: Alan Cox <alan@linux.intel.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
jirislaby@gmail.com
Subject: Re: [PATCH 18/41] TTY: pty, switch to tty_alloc_driver
Date: Wed, 8 Aug 2012 16:37:57 +0100 [thread overview]
Message-ID: <20120808163757.28a28df1@bob.linux.org.uk> (raw)
In-Reply-To: <1344368886-24033-19-git-send-email-jslaby@suse.cz>
On Tue, 7 Aug 2012 21:47:43 +0200
Jiri Slaby <jslaby@suse.cz> wrote:
> Switch to the new driver allocation interface, as this is one of the
> special call-sites. Here, we need TTY_DRIVER_EXCESSIVE_LINES to not
> allocate tty_driver->ports, cdevs and potentially other structures
> because we reserve too many lines in pty. Instead, it provides the
> tty_port<->tty_struct link in tty->ops->install already.
This is the only thing I would quibble about in the entire patch set.
We've got a pile of things that the pty does and one or two other
drivers might want to do about dynamic allocation (termios objects is
the same problem).
I think it's a mistake to call it EXCESSIVE_LINES, better a name which
indicates what it implies - say TTY_DRIVER_DYNAMIC_ALLOC. Then it means
other drivers can move that way if they wish.
Otherwise
Acked-by: Alan Cox <alan@linux.intel.com>
for the entire series, and next time we are both at the same conference
I owe you a a couple of beers at least !
next prev parent reply other threads:[~2012-08-08 15:20 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 19:47 [PATCH 00/41] TTY buffer in tty_port -- prep no. 4 Jiri Slaby
2012-08-07 19:47 ` [PATCH 01/41] TTY: pty, stop passing NULL to free_tty_struct Jiri Slaby
2012-08-07 19:47 ` [PATCH 02/41] TTY: 68328serial, fix compilation Jiri Slaby
2012-08-08 15:24 ` Alan Cox
2012-08-08 19:33 ` Jiri Slaby
2012-08-07 19:47 ` [PATCH 03/41] TTY: n_gsm, use tty_port_install Jiri Slaby
2012-08-07 19:47 ` [PATCH 04/41] misc: pti, add const to pci_device_id table Jiri Slaby
2012-08-07 19:47 ` [PATCH 05/41] misc: pti, pci drvdata cannot be NULL in ->remove Jiri Slaby
2012-08-07 19:47 ` [PATCH 06/41] misc: pti, stop using iomap's unmap on ioremap space Jiri Slaby
2012-08-07 19:47 ` [PATCH 07/41] misc: pti, move ->remove to the PCI code Jiri Slaby
2012-08-07 19:47 ` [PATCH 08/41] misc: pti, do the opposite of ->probe in ->remove Jiri Slaby
2012-08-07 19:47 ` [PATCH 09/41] misc: pti, fix fail paths Jiri Slaby
2012-08-07 19:47 ` [PATCH 10/41] misc: pti, fix tty_port count Jiri Slaby
2012-08-07 19:47 ` [PATCH 11/41] misc: pti, use tty_port_register_device Jiri Slaby
2012-08-07 19:47 ` [PATCH 12/41] mxser: allow overlapping vector Jiri Slaby
2012-08-13 1:50 ` Rusty Russell
2012-08-13 7:23 ` Jiri Slaby
2012-08-13 8:16 ` [PATCH] TTY: mxser, fix invalid module_parm permissions Jiri Slaby
2012-08-13 8:18 ` Jiri Slaby
2012-08-07 19:47 ` [PATCH 13/41] TTY: ttyprintk, unregister tty driver on failure Jiri Slaby
2012-08-07 19:47 ` [PATCH 14/41] TTY: ttyprintk, don't touch behind tty->write_buf Jiri Slaby
2012-08-07 19:47 ` [PATCH 15/41] TTY: ttyprintk, initialize tty_port earlier Jiri Slaby
2012-08-07 19:47 ` [PATCH 16/41] TTY: tty3270, free tty driver properly Jiri Slaby
2012-08-07 19:47 ` [PATCH 17/41] TTY: pass flags to alloc_tty_driver Jiri Slaby
2012-08-07 19:47 ` [PATCH 18/41] TTY: pty, switch to tty_alloc_driver Jiri Slaby
2012-08-08 15:37 ` Alan Cox [this message]
2012-08-08 20:11 ` Jiri Slaby
2012-08-08 22:19 ` Alan Cox
2012-08-07 19:47 ` [PATCH 19/41] TTY: move allocations " Jiri Slaby
2012-08-07 19:47 ` [PATCH 20/41] TTY: add support for unnumbered device nodes Jiri Slaby
2012-08-07 19:47 ` [PATCH 21/41] TTY: move cdev_add to tty_register_device Jiri Slaby
2012-08-07 19:47 ` [PATCH 22/41] TTY: use tty_port_register_device Jiri Slaby
2012-08-07 19:47 ` [PATCH 23/41] TTY: automatically create nodes for some drivers Jiri Slaby
2012-08-07 19:47 ` [PATCH 24/41] TTY: tty_port, add some documentation Jiri Slaby
2012-08-07 19:47 ` [PATCH 25/41] TTY: add tty_port_link_device Jiri Slaby
2012-08-07 19:47 ` [PATCH 26/41] TTY: use tty_port_link_device Jiri Slaby
2012-08-07 19:47 ` [PATCH 27/41] TTY: synclink_cs, sanitize fail paths Jiri Slaby
2012-08-07 19:47 ` [PATCH 28/41] TTY: synclink_cs, use dynamic tty devices Jiri Slaby
2012-08-07 19:47 ` [PATCH 29/41] TTY: synclink_cs, final cleanup in synclink_cs_init Jiri Slaby
2012-08-07 19:47 ` [PATCH 30/41] TTY: moxa, convert to dynamic device Jiri Slaby
2012-08-07 19:47 ` [PATCH 31/41] TTY: nfcon, add tty_port and link it Jiri Slaby
2012-08-07 19:47 ` [PATCH 32/41] TTY: con3215, unset raw3215[line] Jiri Slaby
2012-08-07 19:47 ` [PATCH 33/41] TTY: con3215, add tty install Jiri Slaby
2012-08-07 19:47 ` [PATCH 34/41] TTY: i4l, " Jiri Slaby
2012-08-07 19:48 ` [PATCH 35/41] TTY: synclink, " Jiri Slaby
2012-08-07 19:48 ` [PATCH 36/41] TTY: synclinkmp, " Jiri Slaby
2012-08-07 19:48 ` [PATCH 37/41] TTY: ircomm_tty, " Jiri Slaby
2012-08-07 19:48 ` [PATCH 38/41] TTY: tty3270, " Jiri Slaby
2012-08-07 19:48 ` [PATCH 39/41] TTY: hvc_console, " Jiri Slaby
2012-08-07 19:48 ` [PATCH 40/41] TTY: hvcs, clean hvcs_open a bit Jiri Slaby
2012-08-07 19:48 ` [PATCH 41/41] TTY: hvcs, add tty install Jiri Slaby
2012-08-08 20:26 ` [PATCH v2 18/41] TTY: pty, switch to tty_alloc_driver Jiri Slaby
2012-08-08 20:26 ` [PATCH v2 19/41] TTY: move allocations " Jiri Slaby
2012-08-08 20:26 ` [PATCH v2 20/41] TTY: add support for unnumbered device nodes Jiri Slaby
2012-08-08 20:26 ` [PATCH v2 21/41] TTY: move cdev_add to tty_register_device Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120808163757.28a28df1@bob.linux.org.uk \
--to=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox