Re: [Regression, post-3.5] System suspend broken on the Mackerel board

[Paul Mundt <lethal@linux-sh.org>]

On Wed, Aug 08, 2012 at 11:23:04AM +0200, Rafael J. Wysocki wrote:
> On Tuesday, August 07, 2012, Paul Mundt wrote:
> > On Sun, Aug 05, 2012 at 12:02:43AM +0200, Rafael J. Wysocki wrote:
> > > On Wednesday, August 01, 2012, Paul Mundt wrote:
> > > > Turns out we can just collapse the probe/init stuff anyways, so this
> > > > ought to fix it. I've verified that it fixes Morimoto-san's issue, my
> > > > expectation is that the mackerel case is likewise getting tripped up but
> > > > no one bothered implementing any error detecting logic for gpio_request()
> > > > failing, so it doesn't fail gracefully.
> > > > 
> > > > I'll be pushing this out to Linus shortly:
> > > 
> > > Thanks, this helped.  Resume works correctly on Mackerel with 3.6-rc1.
> > > 
> > > However, I'm now seeing a different problem related to system suspend on that,
> > > board which is that sh7372_enter_a3sm_common() returns immediately, as though
> > > at least one of the wakeup signals was permanently asserted.  This hadn't
> > > happened before your last pull request was merged, so I suspect that one
> > > of the irqdomain patches might introduce this behavior.
> > > 
> > Ok, I'll back off the irqdomain selection until we have a chance to test
> > it more on the other platforms.
> 
> If you mean removing the select from drivers/sh/intc/Kconfig, that alone doesn't
> help.  Reverting commit 1d6a21b0a672fb29b01ccf397d478e0541e17716
> (sh: intc: initial irqdomain support.) helps, though.
> 
Yeah, I see what happened now. I inadvertently trampled the -EEXIST
behaviour. I've taken care of it now, so hopefully you'll have better
luck with -rc2!