From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Feng Tang <feng.tang@intel.com>
Cc: Axel Lin <axel.lin@gmail.com>,
linux-kernel@vger.kernel.org,
Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH] wm831x-dcdc: fix coccinelle warnings of missing IRQF_ONESHOT
Date: Fri, 10 Aug 2012 11:04:57 +0100 [thread overview]
Message-ID: <20120810100456.GF24328@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1344560304-4322-1-git-send-email-feng.tang@intel.com>
On Fri, Aug 10, 2012 at 08:58:24AM +0800, Feng Tang wrote:
> From: Fengguang Wu <fengguang.wu@intel.com>
>
> /c/kernel-tests/src/linux/drivers/regulator/wm831x-dcdc.c:829:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
> /c/kernel-tests/src/linux/drivers/regulator/wm831x-dcdc.c:695:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
> /c/kernel-tests/src/linux/drivers/regulator/wm831x-dcdc.c:533:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
> /c/kernel-tests/src/linux/drivers/regulator/wm831x-dcdc.c:542:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
> Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
> Make sure threaded IRQs without a primary handler are always request with
> IRQF_ONESHOT
This is actually a false positive - _ONESHOT is only needed for
interrupts without a primary handler if the interrupt controller is not
threaded. For this driver (and most of the other wm831x drivers, as
well as many other MFDs) we are guaranteed that the primary handler can
never be called. It's not going to hurt, though.
prev parent reply other threads:[~2012-08-10 10:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 0:58 [PATCH] wm831x-dcdc: fix coccinelle warnings of missing IRQF_ONESHOT Feng Tang
2012-08-10 10:04 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120810100456.GF24328@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=feng.tang@intel.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox