* [PATCH 2/3 V1] block: Fix not tracing all device plug-operation.
@ 2012-08-11 1:32 Jianpeng Ma
0 siblings, 0 replies; only message in thread
From: Jianpeng Ma @ 2012-08-11 1:32 UTC (permalink / raw)
To: axboe; +Cc: Shaohua Li, linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 1335 bytes --]
If process handled two or more devices,there will not be trace some
devices plug-operation.
V0-->V1
Fix a bug when insert a req to plug-list which already had the same request-queue, it should
used list_add not list_add_tail.
Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
block/blk-core.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index 7a3abc6..034f186 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -1521,11 +1521,25 @@ get_rq:
struct request *__rq;
__rq = list_entry_rq(plug->list.prev);
- if (__rq->q != q)
+ if (__rq->q != q) {
plug->should_sort = 1;
+ trace_block_plug(q);
+ }
+ } else {
+ struct request *__rq;
+ list_for_each_entry_reverse(__rq, &plug->list,
+ queuelist) {
+ if (__rq->q == q) {
+ list_add(&req->queuelist,
+ &__rq->queuelist);
+ goto stat_acct;
+ }
+ }
+ trace_block_plug(q);
}
}
list_add_tail(&req->queuelist, &plug->list);
+stat_acct:
drive_stat_acct(req, 1);
} else {
spin_lock_irq(q->queue_lock);
--
1.7.9.5
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-08-11 1:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-11 1:32 [PATCH 2/3 V1] block: Fix not tracing all device plug-operation Jianpeng Ma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox