From: Daniel Vetter <daniel@ffwll.ch>
To: Takashi Iwai <tiwai@suse.de>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Hugh Dickins <hughd@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Chris Wilson <chris@chris-wilson.co.uk>,
Giacomo Comes <comes@naic.edu>,
Paulo Zanoni <paulo.r.zanoni@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/i915: Fix blank panel at reopening lid
Date: Sat, 11 Aug 2012 21:15:53 +0200 [thread overview]
Message-ID: <20120811191553.GA5132@phenom.ffwll.local> (raw)
In-Reply-To: <s5hsjbt9as5.wl%tiwai@suse.de>
On Sat, Aug 11, 2012 at 08:56:42AM +0200, Takashi Iwai wrote:
> When you reopen the lid on a laptop with PCH, the panel suddenly goes
> blank sometimes. It seems because BLC_PWM_CPU_CTL register is cleared
> to zero when BLC_PWM_CPU_CTL2 and BLC_PWM_PCH_CTL1 registers are
> enabled.
>
> This patch fixes the problem by moving the call of the function setting
> BLC_PWM_CPU_CTL after enabling other two registers.
>
> Reported-and-tested-by: Hugh Dickins <hughd@google.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
> v1->v2: add comments, fixed changelog
Picked up for -fixes, thanks for the patch.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
prev parent reply other threads:[~2012-08-11 19:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-04 17:01 i915 regression on 3.6-rc1: lid blanks screen Hugh Dickins
2012-08-05 7:11 ` Takashi Iwai
2012-08-06 4:21 ` Hugh Dickins
2012-08-06 9:03 ` Daniel Vetter
2012-08-06 18:25 ` Hugh Dickins
2012-08-10 11:59 ` Takashi Iwai
2012-08-10 12:35 ` Daniel Vetter
2012-08-10 12:57 ` Takashi Iwai
2012-08-10 18:53 ` Hugh Dickins
2012-08-11 6:45 ` Takashi Iwai
2012-08-11 6:56 ` [PATCH v2] drm/i915: Fix blank panel at reopening lid Takashi Iwai
2012-08-11 19:15 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120811191553.GA5132@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=comes@naic.edu \
--cc=daniel.vetter@ffwll.ch \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulo.r.zanoni@intel.com \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox