From: Ralf Baechle <ralf@linux-mips.org>
To: Huacai Chen <chenhc@lemote.com>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
Fuxin Zhang <zhangfx@lemote.com>,
Zhangjin Wu <wuzhangjin@gmail.com>,
Hongliang Tao <taohl@lemote.com>, Hua Yan <yanh@lemote.com>,
Yong Zhang <yong.zhang@windriver.com>,
stable@vger.kernel.org
Subject: Re: [PATCH V2] MIPS: Fix poweroff failure when HOTPLUG_CPU configured.
Date: Tue, 14 Aug 2012 13:48:56 +0200 [thread overview]
Message-ID: <20120814114856.GA17040@linux-mips.org> (raw)
In-Reply-To: <1344862344-27434-1-git-send-email-chenhc@lemote.com>
On Mon, Aug 13, 2012 at 08:52:24PM +0800, Huacai Chen wrote:
> When poweroff machine, kernel_power_off() call disable_nonboot_cpus().
> And if we have HOTPLUG_CPU configured, disable_nonboot_cpus() is not an
> empty function but attempt to actually disable the nonboot cpus. Since
> system state is SYSTEM_POWER_OFF, play_dead() won't be called and thus
> disable_nonboot_cpus() hangs. Therefore, we make this patch to avoid
> poweroff failure.
> diff --git a/arch/mips/kernel/process.c b/arch/mips/kernel/process.c
> index e9a5fd7..69b17a9 100644
> --- a/arch/mips/kernel/process.c
> +++ b/arch/mips/kernel/process.c
> @@ -72,9 +72,7 @@ void __noreturn cpu_idle(void)
> }
> }
> #ifdef CONFIG_HOTPLUG_CPU
> - if (!cpu_online(cpu) && !cpu_isset(cpu, cpu_callin_map) &&
> - (system_state == SYSTEM_RUNNING ||
> - system_state == SYSTEM_BOOTING))
> + if (!cpu_online(cpu) && !cpu_isset(cpu, cpu_callin_map))
Looks good - but I'm wondering if the "!cpu_isset(cpu, cpu_callin_map)"
can be removed as well?
Also, which -stable branches is this patch applicable?
Ralf
next prev parent reply other threads:[~2012-08-14 11:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 12:52 [PATCH V2] MIPS: Fix poweroff failure when HOTPLUG_CPU configured Huacai Chen
2012-08-14 11:48 ` Ralf Baechle [this message]
2012-08-14 14:24 ` Huacai Chen
2012-08-16 3:47 ` Huacai Chen
2012-08-18 17:50 ` Kevin Cernekee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814114856.GA17040@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=chenhc@lemote.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=stable@vger.kernel.org \
--cc=taohl@lemote.com \
--cc=wuzhangjin@gmail.com \
--cc=yanh@lemote.com \
--cc=yong.zhang@windriver.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).