From: Tejun Heo <tj@kernel.org>
To: Marc Dietrich <marvin24@gmx.de>
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, mingo@redhat.com,
lauro.venancio@openbossa.org, jak@jak-linux.org,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Alasdair Kergon <agk@redhat.com>,
Aloisio Almeida Jr <aloisio.almeida@openbossa.org>,
Samuel Ortiz <sameo@linux.intel.com>, Rob Clark <rob@ti.com>,
Christine Caulfield <ccaulfie@redhat.com>,
Steven Whitehouse <swhiteho@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
Sage Weil <sage@inktank.com>
Subject: Re: [PATCH 6/6] workqueue: deprecate WQ_NON_REENTRANT
Date: Tue, 14 Aug 2012 10:35:31 -0700 [thread overview]
Message-ID: <20120814173531.GP25632@google.com> (raw)
In-Reply-To: <2904218.ZgtLmH5Irc@ax5200p>
Hello,
On Tue, Aug 14, 2012 at 07:24:59PM +0200, Marc Dietrich wrote:
> the nvec driver had its own workqueue because we found that it reduced some
> timimg induced protocol errors. I just tested your patch which uses the system
> workqueue and I failed to reproduce these protocol errors under stress
> testing, so I think it's ok.
Thanks, there shouldn't be any difference whether you use system_wq or
your own.
> Because this is a single patch affecting many drivers, is this going through
> linux-next or some subsystem tree? Maybe it would have been better to split it
> in one patch per driver. Otherwise ...
I generally think it's better to do quick one time conversion for
things like this, but this patch is rather borderline. It might be
better to separate out the non trivialones and route them separately.
I'll think more about it.
Thanks.
--
tejun
next prev parent reply other threads:[~2012-08-14 17:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 1:49 [PATCHSET] workqueue: make all workqueues non-reentrant Tejun Heo
2012-08-14 1:49 ` [PATCH 1/6] " Tejun Heo
2012-08-14 1:49 ` [PATCH 2/6] workqueue: gut flush[_delayed]_work_sync() Tejun Heo
2012-08-14 1:49 ` [PATCH 3/6] workqueue: gut system_nrt[_freezable]_wq() Tejun Heo
2012-08-14 1:49 ` [PATCH 5/6] workqueue: deprecate system_nrt[_freezable]_wq Tejun Heo
2012-08-20 2:56 ` Lai Jiangshan
2012-08-14 1:49 ` [PATCH 6/6] workqueue: deprecate WQ_NON_REENTRANT Tejun Heo
2012-08-14 17:24 ` Marc Dietrich
2012-08-14 17:35 ` Tejun Heo [this message]
2012-08-20 21:54 ` [PATCHSET] workqueue: make all workqueues non-reentrant Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814173531.GP25632@google.com \
--to=tj@kernel.org \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aloisio.almeida@openbossa.org \
--cc=ccaulfie@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=hch@infradead.org \
--cc=jak@jak-linux.org \
--cc=lauro.venancio@openbossa.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=mingo@redhat.com \
--cc=rob@ti.com \
--cc=sage@inktank.com \
--cc=sameo@linux.intel.com \
--cc=stefanr@s5r6.in-berlin.de \
--cc=swhiteho@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).